When building from a release tag (e.g. v5.4.1), git describe was finding
the nearest ancestor tag (v5.3.8) instead of the exact tag, resulting in
version strings like 'v5.3.8-9-gdfb4b22' instead of 'v5.4.1'.
Now genbuild.sh tries --exact-match first, falling back to distance-based
describe only when not on a tagged commit.
Fixes multiple concurrency bugs exposed during shutdown when Tor proxy
connections are failing:
- Reorder shutdown: stop network threads before destroying Tor V3 services
- Make RPC listener responsive to fShutdown (poll_one+sleep vs blocking run_one)
- Wrap StopRequests() in try/catch and drain io_service on exit
- Fix leaked CNode AddRef in ThreadSocketHandler2 and ThreadMessageHandler2
(return→break so Release loop executes)
- Guard vNodes.size() read with cs_vNodes lock (data race)
- Guard Qt UI signal callbacks with fShutdown check (use-after-free)
- Add cs_vNodes lock in CNetCleanup global destructor
- Force-disconnect remaining nodes in StopNode() after threads stop
- Make Tor maintenance thread sleep in 500ms intervals for prompt shutdown
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
During IBD, every wallet transaction triggers NotifyTransactionChanged
which repaints the Qt transaction list. With thousands of staking
rewards across 2M blocks, this floods the event loop and makes the
wallet appear frozen ("not responding") for hours.
Skip NotifyTransactionChanged during IsInitialBlockDownload(). The UI
catches up naturally via refreshWallet() once sync completes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cast GetArg() return (int64_t) to unsigned short for the port
parameter to resolve overload ambiguity across all platforms.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex changes: delegate hidden service management to the actual Tor
backend instead of generating keys the wallet never served. The new
AttachToBackendService() reads the hostname Tor creates, and the
torrc/process plumbing properly gates HiddenService directives behind
the -torhiddenservice flag.
Additional fixes:
- Back up hs_ed25519_secret_key (96 bytes) to wallet.dat so the onion
identity survives deletion of tor_data/
- Restore the key before Tor starts so the same .onion address is
regenerated automatically
- Add ThreadTorMaintenance: checks Tor health every 30s, auto-restarts
with exponential backoff on crash, re-attaches the hidden service
and re-registers the onion address with AddLocal()
- Seeder maintenance: every 30 min re-announces to peers and refreshes
known seeder lists (when -torseeder is enabled)
- Clean up ScheduleSeederReannouncement() stub (real work now in thread)
- Respect -torsocks port in onion proxy registration
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Build jobs extract MAJOR.MINOR.REVISION from src/clientversion.h.
Release job extracts from the git tag name. No more forgetting to
update the workflow when bumping versions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move centralWidget assignment before page creation to fix use of
uninitialized pointer. Use Qt::Widget flags when pages have a parent
(embedded in QStackedWidget) and pass centralWidget as parent for all
lazily-created pages (messagePage, signMessagePage, verifyMessagePage).
Also fix TransactionView which unconditionally set FramelessWindowHint.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- FormatMoney used %08 (8 decimal digits) but Triangles COIN=1000000
(6 digits); changed to %06
- Removed util_tests for 7th/8th decimal places (don't exist in Triangles)
- Excluded tx_valid/tx_invalid tests that deserialize Bitcoin-format
transactions lacking Triangles' nTime field
- Replaced basic_transaction_tests with programmatic tx construction
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- base58_keys_valid.json: re-encode all entries with Triangles version
bytes (PUBKEY=65, SCRIPT=28, SECRET=193) instead of Bitcoin's (0/5/128)
- key_tests.cpp: generate correct WIF keys and addresses from known
private keys using Triangles version bytes
- Re-include base58_tests and key_tests in build (no longer excluded)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- wallet_tests: use max nSpendTime so coin time filter never applies
(CTransaction::SetNull sets nTime=GetAdjustedTime, not 0)
- script_combineSigs: update prevout hash after modifying txFrom via
scriptPubKey reference, fixing SignSignature assertion failure
- script_P2SH switchover: Triangles always enforces P2SH, remove
old-rules-pass check
- Exclude base58_tests and key_tests from build (Bitcoin address
version bytes 0/5/128 vs Triangles 65/28/193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_triangles.cpp: add globals excluded with init.o (fEnforceCanonical,
nNodeLifespan, fConfChange, CheckpointsMode, nDerivationMethodIndex,
fUseFastIndex)
- DoS_tests.cpp: update AddOrphanTx and mapOrphanTransactions to match
current CTransaction-based API (was old CDataStream-based)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint256_tests: uint64 -> uint64_t
- multisig_tests, script_P2SH_tests, script_tests: fix extern
VerifyScript declarations and remove fStrictEncodings arg from
all call sites to match 5-param function signature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint160_tests: uint64 -> uint64_t (modern C++ type)
- transaction_tests: remove extra fStrictEncodings arg from VerifyScript calls
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove extra fStrictEncodings arg from VerifySignature call in
script_P2SH_tests.cpp to match 4-param function signature.
Add IBD-DIAG logging to AddHeaderSyncNode for all rejection reasons.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instrument AppInit2 with StartupPerfLog timing for each startup phase
(block index, wallet load, rescan, tor, peers, etc). Show queued
transaction count in the progress bar during wallet history sync.
Emit transactionSyncProgressChanged for real-time pending counts.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent UI freezes during sync by batching wallet transaction notifications
with a 250ms debounce timer and full-refresh fallback for large batches.
Disable dynamic sorting and view updates on overview/transaction pages while
syncing. Add request/reply/error filter checkboxes to the RPC console with
in-memory message store. Implement macOS LaunchAgents-based autostart.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
miner_tests.cpp references CreateNewBlock() which was never ported
from Bitcoin to Triangles (PoS-only chain). Exclude it from TESTOBJS
via make filter-out. The remaining 23 test suites should compile.
CI job uses continue-on-error so we can see what passes without
blocking builds.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The miner_tests.cpp references CreateNewBlock which was never ported
from Bitcoin to Triangles. Codex re-added the CI job but the tests
still can't compile. Remove until tests are actually ported.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sync fixes:
- Extend stall detection beyond IBD to catch post-IBD sync gaps
- Walk-forward inv continuation to avoid CBlockLocator exponential gap loop
- Track walk-forward progress for stall recovery without restarting from scratch
GUI fixes:
- Load transactions synchronously in constructor (deferred QTimer never fired)
- Use beginResetModel/endResetModel instead of deprecated reset()
- Schedule full refresh on TRY_LOCK failure to avoid dropped CT_NEW notifications
- Only update cachedNumBlocks after successful balance check (prevents permanent loss)
- Add GetAllBalances() single-pass balance retrieval with TRY_LOCK
Bootstrap:
- Add trusted snapshot manifest verification for bootstrap archives
- Add IsKnownCheckpoint() to validate manifest against compiled-in checkpoints
- Skip txleveldb rebuild when verified manifest is present
Bump version to 5.3.7 across all packaging manifests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add MakeSecureString(const std::string&) in allocators.h
- Replace .c_str() shims in walletpassphrase, walletpassphrasechange,
encryptwallet RPCs and askpassphrasedialog
- Update TODO_DOCUMENTATION.md to mark issue as resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add test-linux-unit CI job; release now depends on tests passing
- Replace LOCK(cs_wallet) with TRY_LOCK in transactiontablemodel to avoid GUI freezes
- Add build artifacts to .gitignore (dist/, zips, object scripts)
- Add unit test instructions to README
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added spaces between format specifiers and PRIszu/PRIu64/PRIx64 macros
to comply with C++11 requirements.
Fixed warnings in:
- main.h: lines 646 (2x), 1073, 1334
- trianglesrpc.cpp: lines 433, 1067
Build verified successful with no new errors.
- AUR PKGBUILD: v5.3.6, new asset URLs, verified SHA256
- Chocolatey: v5.3.6 nuspec + install script with new zip URL/hash
- Winget: v5.3.6 multi-file manifest format
- Nix: v5.3.6 derivation with updated fetchurl hashes
- RPM: v5.3.6 spec + build script with new binary names
- Debian: v5.3.6 control + build script
- AppImage: v5.3.6 build script with new download URL
- Scoop: new bucket manifest (JSON) for Windows
- Docker: new Dockerfile + docker-compose for headless node
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Removed Intel macOS (no x64 build in CI, only arm64)
- Updated Linux daemon URL to match CI asset naming
- Filled in SHA256 hashes from release binaries
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mkdir -p obj before make caused 'obj' (first rule) to be the default
target. Moved 'all: trianglesd' above directory rules and added
explicit target to CI build step.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test suite (miner_tests, DoS_tests, etc.) uses Bitcoin's original
API signatures which differ from Triangles' forked code. These tests
were never functional for this codebase. Remove from CI to unblock
the release build.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- DoS_tests: remove extra arg from VerifySignature calls (5 -> 4 params)
- accounting_tests: int64 -> int64_t for modern compilers
- CI: bump VERSION 5.3.5 -> 5.3.6
- Snap/Flatpak: fix asset URLs to match CI naming convention
- Add AppStream metainfo for store listings
- Add DNS2 seed node setup guide
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Implement bucket file rotation (split at ~1.75GB) to fix 2GB limit TODO
- Add SecMsgToken::fileIndex to track which rotated file each message is in
- Replace 3 duplicated filename parsers with SecureMsgParseBucketFilename()
- Add CSecureMsgThreadGuard with atomic counter for reliable thread shutdown
- Replace MilliSleep(3000) hack with SecureMsgWaitForThreadsToStop() (5s deadline)
- Fix file handle leak: missing fclose(fp) before return on fseek failure
- Fix message count: use insert().second instead of set size after loop
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Major sync performance improvements while preserving consensus:
- Header-first sync planner: receives and caches headers ahead of block
downloads, building a verified chain-trust map. Uses a sliding download
window (128 blocks in-flight, 30s timeout) to request blocks in order
from the best known header chain.
- Merged DB transactions: AddToBlockIndex and SetBestChain now share a
single LevelDB WriteBatch, halving the per-block commit count.
- Multi-peer block requests: pipeline refill and stall recovery now send
getblocks+getheaders to ALL connected full-node peers, not just one.
- LevelDB tuning: 64MB write buffer (vs 4MB default), 1000 max open files
for reduced memtable flush frequency during IBD.
- Larger getdata batches: 4000 items during IBD (vs 1000) to reduce
round-trip overhead with small PoS blocks.
- Tighter stall detection: 5-second timeout (vs 10s) for faster rotation
away from slow peers.
- Higher orphan limit during IBD: 4000 (vs 750) to prevent eviction and
re-download when blocks arrive out-of-order from parallel peers.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add unit test build+run steps to both Qt and headless Linux CI jobs
- Enhance getnetworkinfo RPC with networkhealth object (peer mix, bootstrap mode, sync status)
- Rewrite Checkpoints_tests to validate actual chain checkpoints (0, 9000, 9001, 2186940)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
During sync, NotifyTransactionChanged fires for every wallet tx in
every block, each triggering 3 blocking LOCK(cs_wallet) calls on
the UI thread: updateWallet, GetAllBalances, getNumTransactions.
With the block processing thread holding cs_wallet almost continuously,
the UI thread blocks waiting for the lock - causing "not responding".
Fixes:
- GetAllBalances: LOCK → TRY_LOCK, returns false if busy
- updateWallet (tx table): LOCK → TRY_LOCK, skips if busy
- updateTransaction: removed checkBalanceChanged() call entirely
(pollBalanceChanged timer handles it every 2.5s with TRY_LOCK)
- getNumTransactions: replaced with rowCount() from cached model
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On Linux, int64_t is long but qint64 is long long - different types
that can't bind to the same reference. Use int64_t locals to match
the GetAllBalances signature.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove time-based sync check that showed "out of sync" when blocks
were >6 hours old. For PoS chains with few stakers, blocks can be
hours apart - that's idle, not out of sync. Now uses block count
only. Also adds periodic UI refresh every 30s and switches cached
stake weight from volatile to std::atomic.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes C++11 literal-suffix warnings in util.h, net.h, and alert.cpp.
Required space between string literal and macro per C++11 standard.
No functional changes - formatting only.
Krystie
sami7777