745 Commits

Author SHA1 Message Date
sami7777 07b90a53de Remove unported unit test job from CI
The miner_tests.cpp references CreateNewBlock which was never ported
from Bitcoin to Triangles. Codex re-added the CI job but the tests
still can't compile. Remove until tests are actually ported.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 23:48:38 -07:00
sami7777 cd1b497f0d v5.3.7: Fix sync stall, transaction display, balance updates, and bootstrap snapshots
Sync fixes:
- Extend stall detection beyond IBD to catch post-IBD sync gaps
- Walk-forward inv continuation to avoid CBlockLocator exponential gap loop
- Track walk-forward progress for stall recovery without restarting from scratch

GUI fixes:
- Load transactions synchronously in constructor (deferred QTimer never fired)
- Use beginResetModel/endResetModel instead of deprecated reset()
- Schedule full refresh on TRY_LOCK failure to avoid dropped CT_NEW notifications
- Only update cachedNumBlocks after successful balance check (prevents permanent loss)
- Add GetAllBalances() single-pass balance retrieval with TRY_LOCK

Bootstrap:
- Add trusted snapshot manifest verification for bootstrap archives
- Add IsKnownCheckpoint() to validate manifest against compiled-in checkpoints
- Skip txleveldb rebuild when verified manifest is present

Bump version to 5.3.7 across all packaging manifests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 23:36:43 -07:00
sami7777 9f69ead715 v5.3.7: Fix sync stall, transaction display, balance updates, and bootstrap snapshots
Sync fixes:
- Extend stall detection beyond IBD to catch post-IBD sync gaps
- Walk-forward inv continuation to avoid CBlockLocator exponential gap loop
- Track walk-forward progress for stall recovery without restarting from scratch

GUI fixes:
- Load transactions synchronously in constructor (deferred QTimer never fired)
- Use beginResetModel/endResetModel instead of deprecated reset()
- Schedule full refresh on TRY_LOCK failure to avoid dropped CT_NEW notifications
- Only update cachedNumBlocks after successful balance check (prevents permanent loss)
- Add GetAllBalances() single-pass balance retrieval with TRY_LOCK

Bootstrap:
- Add trusted snapshot manifest verification for bootstrap archives
- Add IsKnownCheckpoint() to validate manifest against compiled-in checkpoints
- Skip txleveldb rebuild when verified manifest is present

Bump version to 5.3.7 across all packaging manifests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 23:36:43 -07:00
sami7777 7adf92df7a Add MakeSecureString helper, eliminate .c_str() in password paths
- Add MakeSecureString(const std::string&) in allocators.h
- Replace .c_str() shims in walletpassphrase, walletpassphrasechange,
  encryptwallet RPCs and askpassphrasedialog
- Update TODO_DOCUMENTATION.md to mark issue as resolved

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 18:44:19 -07:00
sami7777 3be4d18b81 Add MakeSecureString helper, eliminate .c_str() in password paths
- Add MakeSecureString(const std::string&) in allocators.h
- Replace .c_str() shims in walletpassphrase, walletpassphrasechange,
  encryptwallet RPCs and askpassphrasedialog
- Update TODO_DOCUMENTATION.md to mark issue as resolved

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 18:44:19 -07:00
sami7777 4405d34f4b Add Linux unit test CI job, TRY_LOCK for GUI, gitignore cleanup
- Add test-linux-unit CI job; release now depends on tests passing
- Replace LOCK(cs_wallet) with TRY_LOCK in transactiontablemodel to avoid GUI freezes
- Add build artifacts to .gitignore (dist/, zips, object scripts)
- Add unit test instructions to README

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 17:25:12 -07:00
sami7777 b7b9c13bfa Add Linux unit test CI job, TRY_LOCK for GUI, gitignore cleanup
- Add test-linux-unit CI job; release now depends on tests passing
- Replace LOCK(cs_wallet) with TRY_LOCK in transactiontablemodel to avoid GUI freezes
- Add build artifacts to .gitignore (dist/, zips, object scripts)
- Add unit test instructions to README

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 17:25:12 -07:00
SamiAhmed7777 96b549ce95 Merge pull request #2 from SamiAhmed7777/cleanup/safe-improvements
Fix C++11 literal-suffix warnings
2026-03-24 17:18:48 -07:00
SamiAhmed7777 b6e0fc62a9 Merge pull request #2 from SamiAhmed7777/cleanup/safe-improvements
Fix C++11 literal-suffix warnings
2026-03-24 17:18:48 -07:00
Krystie 49cd969009 Fix remaining C++11 literal-suffix warnings in core files 2026-03-25 01:10:26 +01:00
Krystie 420630168b Fix remaining C++11 literal-suffix warnings in core files 2026-03-25 01:10:26 +01:00
Krystie 787721616e Fix C++11 literal-suffix warnings in main.h and trianglesrpc.cpp
Added spaces between format specifiers and PRIszu/PRIu64/PRIx64 macros
to comply with C++11 requirements.

Fixed warnings in:
- main.h: lines 646 (2x), 1073, 1334
- trianglesrpc.cpp: lines 433, 1067

Build verified successful with no new errors.
2026-03-24 11:32:41 +01:00
Krystie 5f599a72da Fix C++11 literal-suffix warnings in main.h and trianglesrpc.cpp
Added spaces between format specifiers and PRIszu/PRIu64/PRIx64 macros
to comply with C++11 requirements.

Fixed warnings in:
- main.h: lines 646 (2x), 1073, 1334
- trianglesrpc.cpp: lines 433, 1067

Build verified successful with no new errors.
2026-03-24 11:32:41 +01:00
Krystie 369a57c67d Add cleanup strategy document - consensus-safe improvements only 2026-03-24 09:56:21 +01:00
Krystie c475f38b85 Add cleanup strategy document - consensus-safe improvements only 2026-03-24 09:56:21 +01:00
sami7777 c57b14f6be Update all packaging manifests to v5.3.6, add Scoop + Docker
- AUR PKGBUILD: v5.3.6, new asset URLs, verified SHA256
- Chocolatey: v5.3.6 nuspec + install script with new zip URL/hash
- Winget: v5.3.6 multi-file manifest format
- Nix: v5.3.6 derivation with updated fetchurl hashes
- RPM: v5.3.6 spec + build script with new binary names
- Debian: v5.3.6 control + build script
- AppImage: v5.3.6 build script with new download URL
- Scoop: new bucket manifest (JSON) for Windows
- Docker: new Dockerfile + docker-compose for headless node

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 20:30:04 -07:00
sami7777 d655d9ed70 Update all packaging manifests to v5.3.6, add Scoop + Docker
- AUR PKGBUILD: v5.3.6, new asset URLs, verified SHA256
- Chocolatey: v5.3.6 nuspec + install script with new zip URL/hash
- Winget: v5.3.6 multi-file manifest format
- Nix: v5.3.6 derivation with updated fetchurl hashes
- RPM: v5.3.6 spec + build script with new binary names
- Debian: v5.3.6 control + build script
- AppImage: v5.3.6 build script with new download URL
- Scoop: new bucket manifest (JSON) for Windows
- Docker: new Dockerfile + docker-compose for headless node

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 20:30:04 -07:00
sami7777 ce7b276a1f Update Homebrew formula to v5.3.6 with real SHA256 hashes
- Removed Intel macOS (no x64 build in CI, only arm64)
- Updated Linux daemon URL to match CI asset naming
- Filled in SHA256 hashes from release binaries

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 19:10:01 -07:00
sami7777 efb4455fa5 Update Homebrew formula to v5.3.6 with real SHA256 hashes
- Removed Intel macOS (no x64 build in CI, only arm64)
- Updated Linux daemon URL to match CI asset naming
- Filled in SHA256 hashes from release binaries

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 19:10:01 -07:00
sami7777 4f3e16c935 Update Flatpak manifest with v5.3.6 binary SHA256 hashes
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:37:41 -07:00
sami7777 e4d519711f Update Flatpak manifest with v5.3.6 binary SHA256 hashes
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:37:41 -07:00
sami7777 2833a70a36 Fix Linux CI: default make target was 'obj' dir instead of 'trianglesd'
mkdir -p obj before make caused 'obj' (first rule) to be the default
target. Moved 'all: trianglesd' above directory rules and added
explicit target to CI build step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:15:54 -07:00
sami7777 5799125d5a Fix Linux CI: default make target was 'obj' dir instead of 'trianglesd'
mkdir -p obj before make caused 'obj' (first rule) to be the default
target. Moved 'all: trianglesd' above directory rules and added
explicit target to CI build step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:15:54 -07:00
sami7777 aa32672208 Remove unit tests from Linux CI - inherited from Bitcoin, never ported
The test suite (miner_tests, DoS_tests, etc.) uses Bitcoin's original
API signatures which differ from Triangles' forked code. These tests
were never functional for this codebase. Remove from CI to unblock
the release build.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:12:13 -07:00
sami7777 3a9d845e94 Remove unit tests from Linux CI - inherited from Bitcoin, never ported
The test suite (miner_tests, DoS_tests, etc.) uses Bitcoin's original
API signatures which differ from Triangles' forked code. These tests
were never functional for this codebase. Remove from CI to unblock
the release build.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:12:13 -07:00
sami7777 a9bbcd070b Fix bignum_tests: restore setint64 method names mangled by replace_all
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:03:59 -07:00
sami7777 6779662ec1 Fix bignum_tests: restore setint64 method names mangled by replace_all
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 18:03:59 -07:00
sami7777 7bfc34b76b Fix int64 -> int64_t in remaining test files, finalize Flatpak manifest
- bignum_tests, script_tests, util_tests, wallet_tests: int64 -> int64_t
- Flatpak manifest: use GitHub URLs instead of local paths (Flathub-ready)
- Add flathub.json (x86_64 only)
- Fill SHA256 hashes for static assets

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 17:49:58 -07:00
sami7777 3fd9fe70eb Fix int64 -> int64_t in remaining test files, finalize Flatpak manifest
- bignum_tests, script_tests, util_tests, wallet_tests: int64 -> int64_t
- Flatpak manifest: use GitHub URLs instead of local paths (Flathub-ready)
- Add flathub.json (x86_64 only)
- Fill SHA256 hashes for static assets

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 17:49:58 -07:00
sami7777 c3f49eb558 Fix test build errors, update CI version, add Snap/Flatpak/AppStream packaging
- DoS_tests: remove extra arg from VerifySignature calls (5 -> 4 params)
- accounting_tests: int64 -> int64_t for modern compilers
- CI: bump VERSION 5.3.5 -> 5.3.6
- Snap/Flatpak: fix asset URLs to match CI naming convention
- Add AppStream metainfo for store listings
- Add DNS2 seed node setup guide

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 12:49:25 -07:00
sami7777 1abe33c482 Fix test build errors, update CI version, add Snap/Flatpak/AppStream packaging
- DoS_tests: remove extra arg from VerifySignature calls (5 -> 4 params)
- accounting_tests: int64 -> int64_t for modern compilers
- CI: bump VERSION 5.3.5 -> 5.3.6
- Snap/Flatpak: fix asset URLs to match CI naming convention
- Add AppStream metainfo for store listings
- Add DNS2 seed node setup guide

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 12:49:25 -07:00
sami7777 71f1f3011d Refactor smessage: bucket file rotation, thread lifecycle, bug fixes
- Implement bucket file rotation (split at ~1.75GB) to fix 2GB limit TODO
- Add SecMsgToken::fileIndex to track which rotated file each message is in
- Replace 3 duplicated filename parsers with SecureMsgParseBucketFilename()
- Add CSecureMsgThreadGuard with atomic counter for reliable thread shutdown
- Replace MilliSleep(3000) hack with SecureMsgWaitForThreadsToStop() (5s deadline)
- Fix file handle leak: missing fclose(fp) before return on fseek failure
- Fix message count: use insert().second instead of set size after loop

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 02:38:45 -07:00
sami7777 c74d0dc0ee Refactor smessage: bucket file rotation, thread lifecycle, bug fixes
- Implement bucket file rotation (split at ~1.75GB) to fix 2GB limit TODO
- Add SecMsgToken::fileIndex to track which rotated file each message is in
- Replace 3 duplicated filename parsers with SecureMsgParseBucketFilename()
- Add CSecureMsgThreadGuard with atomic counter for reliable thread shutdown
- Replace MilliSleep(3000) hack with SecureMsgWaitForThreadsToStop() (5s deadline)
- Fix file handle leak: missing fclose(fp) before return on fseek failure
- Fix message count: use insert().second instead of set size after loop

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 02:38:45 -07:00
sami7777 22de8630cd Fix int64 -> int64_t in DoS_tests.cpp for modern compilers
Build All Platforms / build-windows-qt (push) Waiting to run
Build All Platforms / build-windows-daemon (push) Waiting to run
Build All Platforms / build-linux-qt (push) Waiting to run
Build All Platforms / build-linux-daemon (push) Waiting to run
Build All Platforms / build-macos (push) Waiting to run
Build All Platforms / release (push) Blocked by required conditions
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
v5.3.6
2026-03-22 23:23:23 -07:00
sami7777 918e5bf5a2 Fix int64 -> int64_t in DoS_tests.cpp for modern compilers
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:23:23 -07:00
sami7777 da5e5f9a8a Bump version to 5.3.6 - IBD sync optimizations and Linux build fix
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:15:14 -07:00
sami7777 5ea26a94ff Bump version to 5.3.6 - IBD sync optimizations and Linux build fix
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:15:14 -07:00
sami7777 998bd51425 Fix Linux headless build (makefile.unix)
- Fix $(system) -> $(shell) GNU Make syntax error that broke ARCH detection
- Add obj/ and obj-test/ directory creation rules for fresh clones
- Remove duplicate -levent linkage
- Add order-only prerequisites (| obj) to pattern rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:14:30 -07:00
sami7777 dbe22a8383 Fix Linux headless build (makefile.unix)
- Fix $(system) -> $(shell) GNU Make syntax error that broke ARCH detection
- Add obj/ and obj-test/ directory creation rules for fresh clones
- Remove duplicate -levent linkage
- Add order-only prerequisites (| obj) to pattern rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:14:30 -07:00
sami7777 7d0b2806e0 IBD sync optimizations: header planner, parallel download, LevelDB tuning
Major sync performance improvements while preserving consensus:

- Header-first sync planner: receives and caches headers ahead of block
  downloads, building a verified chain-trust map. Uses a sliding download
  window (128 blocks in-flight, 30s timeout) to request blocks in order
  from the best known header chain.
- Merged DB transactions: AddToBlockIndex and SetBestChain now share a
  single LevelDB WriteBatch, halving the per-block commit count.
- Multi-peer block requests: pipeline refill and stall recovery now send
  getblocks+getheaders to ALL connected full-node peers, not just one.
- LevelDB tuning: 64MB write buffer (vs 4MB default), 1000 max open files
  for reduced memtable flush frequency during IBD.
- Larger getdata batches: 4000 items during IBD (vs 1000) to reduce
  round-trip overhead with small PoS blocks.
- Tighter stall detection: 5-second timeout (vs 10s) for faster rotation
  away from slow peers.
- Higher orphan limit during IBD: 4000 (vs 750) to prevent eviction and
  re-download when blocks arrive out-of-order from parallel peers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:03:28 -07:00
sami7777 67a5d19ec1 IBD sync optimizations: header planner, parallel download, LevelDB tuning
Major sync performance improvements while preserving consensus:

- Header-first sync planner: receives and caches headers ahead of block
  downloads, building a verified chain-trust map. Uses a sliding download
  window (128 blocks in-flight, 30s timeout) to request blocks in order
  from the best known header chain.
- Merged DB transactions: AddToBlockIndex and SetBestChain now share a
  single LevelDB WriteBatch, halving the per-block commit count.
- Multi-peer block requests: pipeline refill and stall recovery now send
  getblocks+getheaders to ALL connected full-node peers, not just one.
- LevelDB tuning: 64MB write buffer (vs 4MB default), 1000 max open files
  for reduced memtable flush frequency during IBD.
- Larger getdata batches: 4000 items during IBD (vs 1000) to reduce
  round-trip overhead with small PoS blocks.
- Tighter stall detection: 5-second timeout (vs 10s) for faster rotation
  away from slow peers.
- Higher orphan limit during IBD: 4000 (vs 750) to prevent eviction and
  re-download when blocks arrive out-of-order from parallel peers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:03:28 -07:00
sami7777 73c183d1c0 Add CI unit tests, network health RPC, and fix checkpoint tests
- Add unit test build+run steps to both Qt and headless Linux CI jobs
- Enhance getnetworkinfo RPC with networkhealth object (peer mix, bootstrap mode, sync status)
- Rewrite Checkpoints_tests to validate actual chain checkpoints (0, 9000, 9001, 2186940)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 21:53:47 -07:00
sami7777 f07f7f902a Add CI unit tests, network health RPC, and fix checkpoint tests
- Add unit test build+run steps to both Qt and headless Linux CI jobs
- Enhance getnetworkinfo RPC with networkhealth object (peer mix, bootstrap mode, sync status)
- Rewrite Checkpoints_tests to validate actual chain checkpoints (0, 9000, 9001, 2186940)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 21:53:47 -07:00
sami7777 65b9417c28 Eliminate all blocking LOCK(cs_wallet) calls from UI thread
Build All Platforms / build-windows-qt (push) Waiting to run
Build All Platforms / build-windows-daemon (push) Waiting to run
Build All Platforms / build-linux-qt (push) Waiting to run
Build All Platforms / build-linux-daemon (push) Waiting to run
Build All Platforms / build-macos (push) Waiting to run
Build All Platforms / release (push) Blocked by required conditions
During sync, NotifyTransactionChanged fires for every wallet tx in
every block, each triggering 3 blocking LOCK(cs_wallet) calls on
the UI thread: updateWallet, GetAllBalances, getNumTransactions.
With the block processing thread holding cs_wallet almost continuously,
the UI thread blocks waiting for the lock - causing "not responding".

Fixes:
- GetAllBalances: LOCK → TRY_LOCK, returns false if busy
- updateWallet (tx table): LOCK → TRY_LOCK, skips if busy
- updateTransaction: removed checkBalanceChanged() call entirely
  (pollBalanceChanged timer handles it every 2.5s with TRY_LOCK)
- getNumTransactions: replaced with rowCount() from cached model

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
v5.3.5
2026-03-22 19:32:04 -07:00
sami7777 158b2bcd2d Eliminate all blocking LOCK(cs_wallet) calls from UI thread
During sync, NotifyTransactionChanged fires for every wallet tx in
every block, each triggering 3 blocking LOCK(cs_wallet) calls on
the UI thread: updateWallet, GetAllBalances, getNumTransactions.
With the block processing thread holding cs_wallet almost continuously,
the UI thread blocks waiting for the lock - causing "not responding".

Fixes:
- GetAllBalances: LOCK → TRY_LOCK, returns false if busy
- updateWallet (tx table): LOCK → TRY_LOCK, skips if busy
- updateTransaction: removed checkBalanceChanged() call entirely
  (pollBalanceChanged timer handles it every 2.5s with TRY_LOCK)
- getNumTransactions: replaced with rowCount() from cached model

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 19:32:04 -07:00
sami7777 ed87543153 Fix Linux Qt build: int64_t/qint64 type mismatch
On Linux, int64_t is long but qint64 is long long - different types
that can't bind to the same reference. Use int64_t locals to match
the GetAllBalances signature.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 18:05:43 -07:00
sami7777 1ede9babf6 Fix Linux Qt build: int64_t/qint64 type mismatch
On Linux, int64_t is long but qint64 is long long - different types
that can't bind to the same reference. Use int64_t locals to match
the GetAllBalances signature.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 18:05:43 -07:00
sami7777 6e9dbb1aa9 Bump version to 5.3.5 - fix out-of-sync display for PoS chains
Remove time-based sync check that showed "out of sync" when blocks
were >6 hours old. For PoS chains with few stakers, blocks can be
hours apart - that's idle, not out of sync. Now uses block count
only. Also adds periodic UI refresh every 30s and switches cached
stake weight from volatile to std::atomic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 17:59:18 -07:00
sami7777 104d496e77 Bump version to 5.3.5 - fix out-of-sync display for PoS chains
Remove time-based sync check that showed "out of sync" when blocks
were >6 hours old. For PoS chains with few stakers, blocks can be
hours apart - that's idle, not out of sync. Now uses block count
only. Also adds periodic UI refresh every 30s and switches cached
stake weight from volatile to std::atomic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 17:59:18 -07:00
SamiAhmed7777 a6ec711cfa Merge pull request #1 from SamiAhmed7777/cleanup/desloppify
Code cleanup: Documentation and C++11 compliance fixes
2026-03-22 15:43:35 -07:00