PoS blocks at the same height have identical difficulty, producing equal chain
trust scores. The old "strictly greater" comparison meant first-seen-wins,
causing permanent forks when nodes received competing blocks in different order.
v5.4 fork (block 2186941) adds:
- Deterministic tiebreaker: equal-trust chains resolve to the lower tip hash
- Tighter time drift: ±3 min (was ±10 min), reducing the competing block window
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PoS blocks at the same height have identical difficulty, producing equal chain
trust scores. The old "strictly greater" comparison meant first-seen-wins,
causing permanent forks when nodes received competing blocks in different order.
v5.4 fork (block 2186941) adds:
- Deterministic tiebreaker: equal-trust chains resolve to the lower tip hash
- Tighter time drift: ±3 min (was ±10 min), reducing the competing block window
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When building from a release tag (e.g. v5.4.1), git describe was finding
the nearest ancestor tag (v5.3.8) instead of the exact tag, resulting in
version strings like 'v5.3.8-9-gdfb4b22' instead of 'v5.4.1'.
Now genbuild.sh tries --exact-match first, falling back to distance-based
describe only when not on a tagged commit.
When building from a release tag (e.g. v5.4.1), git describe was finding
the nearest ancestor tag (v5.3.8) instead of the exact tag, resulting in
version strings like 'v5.3.8-9-gdfb4b22' instead of 'v5.4.1'.
Now genbuild.sh tries --exact-match first, falling back to distance-based
describe only when not on a tagged commit.
Fixes multiple concurrency bugs exposed during shutdown when Tor proxy
connections are failing:
- Reorder shutdown: stop network threads before destroying Tor V3 services
- Make RPC listener responsive to fShutdown (poll_one+sleep vs blocking run_one)
- Wrap StopRequests() in try/catch and drain io_service on exit
- Fix leaked CNode AddRef in ThreadSocketHandler2 and ThreadMessageHandler2
(return→break so Release loop executes)
- Guard vNodes.size() read with cs_vNodes lock (data race)
- Guard Qt UI signal callbacks with fShutdown check (use-after-free)
- Add cs_vNodes lock in CNetCleanup global destructor
- Force-disconnect remaining nodes in StopNode() after threads stop
- Make Tor maintenance thread sleep in 500ms intervals for prompt shutdown
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes multiple concurrency bugs exposed during shutdown when Tor proxy
connections are failing:
- Reorder shutdown: stop network threads before destroying Tor V3 services
- Make RPC listener responsive to fShutdown (poll_one+sleep vs blocking run_one)
- Wrap StopRequests() in try/catch and drain io_service on exit
- Fix leaked CNode AddRef in ThreadSocketHandler2 and ThreadMessageHandler2
(return→break so Release loop executes)
- Guard vNodes.size() read with cs_vNodes lock (data race)
- Guard Qt UI signal callbacks with fShutdown check (use-after-free)
- Add cs_vNodes lock in CNetCleanup global destructor
- Force-disconnect remaining nodes in StopNode() after threads stop
- Make Tor maintenance thread sleep in 500ms intervals for prompt shutdown
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
During IBD, every wallet transaction triggers NotifyTransactionChanged
which repaints the Qt transaction list. With thousands of staking
rewards across 2M blocks, this floods the event loop and makes the
wallet appear frozen ("not responding") for hours.
Skip NotifyTransactionChanged during IsInitialBlockDownload(). The UI
catches up naturally via refreshWallet() once sync completes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
During IBD, every wallet transaction triggers NotifyTransactionChanged
which repaints the Qt transaction list. With thousands of staking
rewards across 2M blocks, this floods the event loop and makes the
wallet appear frozen ("not responding") for hours.
Skip NotifyTransactionChanged during IsInitialBlockDownload(). The UI
catches up naturally via refreshWallet() once sync completes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cast GetArg() return (int64_t) to unsigned short for the port
parameter to resolve overload ambiguity across all platforms.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cast GetArg() return (int64_t) to unsigned short for the port
parameter to resolve overload ambiguity across all platforms.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex changes: delegate hidden service management to the actual Tor
backend instead of generating keys the wallet never served. The new
AttachToBackendService() reads the hostname Tor creates, and the
torrc/process plumbing properly gates HiddenService directives behind
the -torhiddenservice flag.
Additional fixes:
- Back up hs_ed25519_secret_key (96 bytes) to wallet.dat so the onion
identity survives deletion of tor_data/
- Restore the key before Tor starts so the same .onion address is
regenerated automatically
- Add ThreadTorMaintenance: checks Tor health every 30s, auto-restarts
with exponential backoff on crash, re-attaches the hidden service
and re-registers the onion address with AddLocal()
- Seeder maintenance: every 30 min re-announces to peers and refreshes
known seeder lists (when -torseeder is enabled)
- Clean up ScheduleSeederReannouncement() stub (real work now in thread)
- Respect -torsocks port in onion proxy registration
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex changes: delegate hidden service management to the actual Tor
backend instead of generating keys the wallet never served. The new
AttachToBackendService() reads the hostname Tor creates, and the
torrc/process plumbing properly gates HiddenService directives behind
the -torhiddenservice flag.
Additional fixes:
- Back up hs_ed25519_secret_key (96 bytes) to wallet.dat so the onion
identity survives deletion of tor_data/
- Restore the key before Tor starts so the same .onion address is
regenerated automatically
- Add ThreadTorMaintenance: checks Tor health every 30s, auto-restarts
with exponential backoff on crash, re-attaches the hidden service
and re-registers the onion address with AddLocal()
- Seeder maintenance: every 30 min re-announces to peers and refreshes
known seeder lists (when -torseeder is enabled)
- Clean up ScheduleSeederReannouncement() stub (real work now in thread)
- Respect -torsocks port in onion proxy registration
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Build jobs extract MAJOR.MINOR.REVISION from src/clientversion.h.
Release job extracts from the git tag name. No more forgetting to
update the workflow when bumping versions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Build jobs extract MAJOR.MINOR.REVISION from src/clientversion.h.
Release job extracts from the git tag name. No more forgetting to
update the workflow when bumping versions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move centralWidget assignment before page creation to fix use of
uninitialized pointer. Use Qt::Widget flags when pages have a parent
(embedded in QStackedWidget) and pass centralWidget as parent for all
lazily-created pages (messagePage, signMessagePage, verifyMessagePage).
Also fix TransactionView which unconditionally set FramelessWindowHint.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move centralWidget assignment before page creation to fix use of
uninitialized pointer. Use Qt::Widget flags when pages have a parent
(embedded in QStackedWidget) and pass centralWidget as parent for all
lazily-created pages (messagePage, signMessagePage, verifyMessagePage).
Also fix TransactionView which unconditionally set FramelessWindowHint.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- FormatMoney used %08 (8 decimal digits) but Triangles COIN=1000000
(6 digits); changed to %06
- Removed util_tests for 7th/8th decimal places (don't exist in Triangles)
- Excluded tx_valid/tx_invalid tests that deserialize Bitcoin-format
transactions lacking Triangles' nTime field
- Replaced basic_transaction_tests with programmatic tx construction
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- FormatMoney used %08 (8 decimal digits) but Triangles COIN=1000000
(6 digits); changed to %06
- Removed util_tests for 7th/8th decimal places (don't exist in Triangles)
- Excluded tx_valid/tx_invalid tests that deserialize Bitcoin-format
transactions lacking Triangles' nTime field
- Replaced basic_transaction_tests with programmatic tx construction
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- base58_keys_valid.json: re-encode all entries with Triangles version
bytes (PUBKEY=65, SCRIPT=28, SECRET=193) instead of Bitcoin's (0/5/128)
- key_tests.cpp: generate correct WIF keys and addresses from known
private keys using Triangles version bytes
- Re-include base58_tests and key_tests in build (no longer excluded)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- base58_keys_valid.json: re-encode all entries with Triangles version
bytes (PUBKEY=65, SCRIPT=28, SECRET=193) instead of Bitcoin's (0/5/128)
- key_tests.cpp: generate correct WIF keys and addresses from known
private keys using Triangles version bytes
- Re-include base58_tests and key_tests in build (no longer excluded)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- wallet_tests: use max nSpendTime so coin time filter never applies
(CTransaction::SetNull sets nTime=GetAdjustedTime, not 0)
- script_combineSigs: update prevout hash after modifying txFrom via
scriptPubKey reference, fixing SignSignature assertion failure
- script_P2SH switchover: Triangles always enforces P2SH, remove
old-rules-pass check
- Exclude base58_tests and key_tests from build (Bitcoin address
version bytes 0/5/128 vs Triangles 65/28/193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- wallet_tests: use max nSpendTime so coin time filter never applies
(CTransaction::SetNull sets nTime=GetAdjustedTime, not 0)
- script_combineSigs: update prevout hash after modifying txFrom via
scriptPubKey reference, fixing SignSignature assertion failure
- script_P2SH switchover: Triangles always enforces P2SH, remove
old-rules-pass check
- Exclude base58_tests and key_tests from build (Bitcoin address
version bytes 0/5/128 vs Triangles 65/28/193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_triangles.cpp: add globals excluded with init.o (fEnforceCanonical,
nNodeLifespan, fConfChange, CheckpointsMode, nDerivationMethodIndex,
fUseFastIndex)
- DoS_tests.cpp: update AddOrphanTx and mapOrphanTransactions to match
current CTransaction-based API (was old CDataStream-based)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_triangles.cpp: add globals excluded with init.o (fEnforceCanonical,
nNodeLifespan, fConfChange, CheckpointsMode, nDerivationMethodIndex,
fUseFastIndex)
- DoS_tests.cpp: update AddOrphanTx and mapOrphanTransactions to match
current CTransaction-based API (was old CDataStream-based)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint256_tests: uint64 -> uint64_t
- multisig_tests, script_P2SH_tests, script_tests: fix extern
VerifyScript declarations and remove fStrictEncodings arg from
all call sites to match 5-param function signature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint256_tests: uint64 -> uint64_t
- multisig_tests, script_P2SH_tests, script_tests: fix extern
VerifyScript declarations and remove fStrictEncodings arg from
all call sites to match 5-param function signature
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint160_tests: uint64 -> uint64_t (modern C++ type)
- transaction_tests: remove extra fStrictEncodings arg from VerifyScript calls
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- uint160_tests: uint64 -> uint64_t (modern C++ type)
- transaction_tests: remove extra fStrictEncodings arg from VerifyScript calls
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove extra fStrictEncodings arg from VerifySignature call in
script_P2SH_tests.cpp to match 4-param function signature.
Add IBD-DIAG logging to AddHeaderSyncNode for all rejection reasons.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove extra fStrictEncodings arg from VerifySignature call in
script_P2SH_tests.cpp to match 4-param function signature.
Add IBD-DIAG logging to AddHeaderSyncNode for all rejection reasons.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instrument AppInit2 with StartupPerfLog timing for each startup phase
(block index, wallet load, rescan, tor, peers, etc). Show queued
transaction count in the progress bar during wallet history sync.
Emit transactionSyncProgressChanged for real-time pending counts.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instrument AppInit2 with StartupPerfLog timing for each startup phase
(block index, wallet load, rescan, tor, peers, etc). Show queued
transaction count in the progress bar during wallet history sync.
Emit transactionSyncProgressChanged for real-time pending counts.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent UI freezes during sync by batching wallet transaction notifications
with a 250ms debounce timer and full-refresh fallback for large batches.
Disable dynamic sorting and view updates on overview/transaction pages while
syncing. Add request/reply/error filter checkboxes to the RPC console with
in-memory message store. Implement macOS LaunchAgents-based autostart.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent UI freezes during sync by batching wallet transaction notifications
with a 250ms debounce timer and full-refresh fallback for large batches.
Disable dynamic sorting and view updates on overview/transaction pages while
syncing. Add request/reply/error filter checkboxes to the RPC console with
in-memory message store. Implement macOS LaunchAgents-based autostart.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
miner_tests.cpp references CreateNewBlock() which was never ported
from Bitcoin to Triangles (PoS-only chain). Exclude it from TESTOBJS
via make filter-out. The remaining 23 test suites should compile.
CI job uses continue-on-error so we can see what passes without
blocking builds.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
miner_tests.cpp references CreateNewBlock() which was never ported
from Bitcoin to Triangles (PoS-only chain). Exclude it from TESTOBJS
via make filter-out. The remaining 23 test suites should compile.
CI job uses continue-on-error so we can see what passes without
blocking builds.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The miner_tests.cpp references CreateNewBlock which was never ported
from Bitcoin to Triangles. Codex re-added the CI job but the tests
still can't compile. Remove until tests are actually ported.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sami7777
SamiAhmed7777