sami7777
4b8d5ab8b1
- Convert 15 typedef declarations to C++11 using aliases across 12 files: script.h (valtype, CTxDestination), serialize.h (CSerializeData), keystore.h (KeyMap, ScriptMap, CryptedKeyMap), sync.h (CCriticalSection, CWaitableCriticalSection), sync.cpp (LockStack), key.h (CPrivKey, CSecret), crypter.h (CKeyingMaterial), allocators.h (SecureString), main.h (MapPrevTx), wallet.h (mapValue_t, removed duplicate), miner.cpp (TxPriority), kernel.cpp (MapModifierCheckpoints) - Remove redundant duplicate mapValue_t typedef in wallet.h - IMPLEMENT_SERIALIZE macro: replace assert() warning suppression with [[maybe_unused]] attributes on fGetSize/fWrite/fRead/nSerSize
128 lines
3.4 KiB
C++
128 lines
3.4 KiB
C++
// Copyright (c) 2011-2012 The Bitcoin developers
|
|
// Distributed under the MIT/X11 software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include "sync.h"
|
|
#include "util.h"
|
|
|
|
|
|
#ifdef DEBUG_LOCKCONTENTION
|
|
void PrintLockContention(const char* pszName, const char* pszFile, int nLine)
|
|
{
|
|
printf("LOCKCONTENTION: %s\n", pszName);
|
|
printf("Locker: %s:%d\n", pszFile, nLine);
|
|
}
|
|
#endif /* DEBUG_LOCKCONTENTION */
|
|
|
|
#ifdef DEBUG_LOCKORDER
|
|
//
|
|
// Early deadlock detection.
|
|
// Problem being solved:
|
|
// Thread 1 locks A, then B, then C
|
|
// Thread 2 locks D, then C, then A
|
|
// --> may result in deadlock between the two threads, depending on when they run.
|
|
// Solution implemented here:
|
|
// Keep track of pairs of locks: (A before B), (A before C), etc.
|
|
// Complain if any thread tries to lock in a different order.
|
|
//
|
|
|
|
struct CLockLocation
|
|
{
|
|
CLockLocation(const char* pszName, const char* pszFile, int nLine)
|
|
{
|
|
mutexName = pszName;
|
|
sourceFile = pszFile;
|
|
sourceLine = nLine;
|
|
}
|
|
|
|
std::string ToString() const
|
|
{
|
|
return mutexName+" "+sourceFile+":"+itostr(sourceLine);
|
|
}
|
|
|
|
private:
|
|
std::string mutexName;
|
|
std::string sourceFile;
|
|
int sourceLine;
|
|
};
|
|
|
|
using LockStack = std::vector<std::pair<void*, CLockLocation>>;
|
|
|
|
static std::mutex dd_mutex;
|
|
static std::map<std::pair<void*, void*>, LockStack> lockorders;
|
|
static thread_local std::unique_ptr<LockStack> lockstack;
|
|
|
|
|
|
static void potential_deadlock_detected(const std::pair<void*, void*>& mismatch, const LockStack& s1, const LockStack& s2)
|
|
{
|
|
printf("POTENTIAL DEADLOCK DETECTED\n");
|
|
printf("Previous lock order was:\n");
|
|
for (const auto& i : s2)
|
|
{
|
|
if (i.first == mismatch.first) printf(" (1)");
|
|
if (i.first == mismatch.second) printf(" (2)");
|
|
printf(" %s\n", i.second.ToString().c_str());
|
|
}
|
|
printf("Current lock order is:\n");
|
|
for (const auto& i : s1)
|
|
{
|
|
if (i.first == mismatch.first) printf(" (1)");
|
|
if (i.first == mismatch.second) printf(" (2)");
|
|
printf(" %s\n", i.second.ToString().c_str());
|
|
}
|
|
}
|
|
|
|
static void push_lock(void* c, const CLockLocation& locklocation, bool fTry)
|
|
{
|
|
if (!lockstack)
|
|
lockstack.reset(new LockStack);
|
|
|
|
if (fDebug) printf("Locking: %s\n", locklocation.ToString().c_str());
|
|
dd_mutex.lock();
|
|
|
|
(*lockstack).push_back({c, locklocation});
|
|
|
|
if (!fTry) {
|
|
for (const auto& i : (*lockstack)) {
|
|
if (i.first == c) break;
|
|
|
|
std::pair<void*, void*> p1 = {i.first, c};
|
|
if (lockorders.count(p1))
|
|
continue;
|
|
lockorders[p1] = (*lockstack);
|
|
|
|
std::pair<void*, void*> p2 = {c, i.first};
|
|
if (lockorders.count(p2))
|
|
{
|
|
potential_deadlock_detected(p1, lockorders[p2], lockorders[p1]);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
dd_mutex.unlock();
|
|
}
|
|
|
|
static void pop_lock()
|
|
{
|
|
if (fDebug)
|
|
{
|
|
const CLockLocation& locklocation = (*lockstack).rbegin()->second;
|
|
printf("Unlocked: %s\n", locklocation.ToString().c_str());
|
|
}
|
|
dd_mutex.lock();
|
|
(*lockstack).pop_back();
|
|
dd_mutex.unlock();
|
|
}
|
|
|
|
void EnterCritical(const char* pszName, const char* pszFile, int nLine, void* cs, bool fTry)
|
|
{
|
|
push_lock(cs, CLockLocation(pszName, pszFile, nLine), fTry);
|
|
}
|
|
|
|
void LeaveCritical()
|
|
{
|
|
pop_lock();
|
|
}
|
|
|
|
#endif /* DEBUG_LOCKORDER */
|