Files

T

sami7777 383a3b8b02 Modernize codebase: C++17, remove Tor v2, add embedded Tor scaffold, IBD speedups

- Replace ~290 BOOST_FOREACH with C++11 range-for across 41+ files
- Replace boost::assign::map_list_of with C++11 brace initialization
- Remove PAIRTYPE macro (no longer needed without BOOST_FOREACH)
- Guard OpenSSL locking callbacks for 3.x (no-ops in >= 1.1.0)
- Fix Qt deprecated APIs for Qt6 compat (QStyleOptionViewItemV4, setResizeMode)
- Add openssl_compat.h version string wrapper
- Enable C++17 in makefile.unix and triangles-qt.pro

- Delete 163 dead Tor v2 source files (~150K lines removed)
- Add embedded Tor scaffold (tor_embedded.h/cpp) using tor_api.h
- Add build-libtor.sh helper and CODEX-TOR-GUIDE.md
- Update makefile.unix and .pro with USE_TOR_EMBEDDED optional flag
- Fallback to external tor_process when not compiled with libtor

- IBD pipeline refill: 100 -> 1000 blocks
- Send/recv buffer limits: unlimited -> 100MB/32MB
- Orphan block cap: unlimited -> 750 with random eviction
- Socket poll: 10ms -> 1ms during IBD
- Message handler sleep: 10ms -> 1ms during IBD
- Stall detection timeout: 5s -> 2s

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-03-19 01:52:40 -07:00

2.2 KiB

Raw Blame History

Embedded Tor Rebase Notes

This repository currently contains a legacy Tor source snapshot under src/tor/, but the wallet target does not build most of that tree.

Current state

The vendored Tor headers report 0.2.5.1-alpha-dev in:
- src/tor/orconfig_linux.h
- src/tor/orconfig_apple.h
- src/tor/orconfig_win32.h
The Qt wallet target currently builds only these Tor-related sources:
- src/tor_embed_hooks.cpp
- src/tor/onion_v3.cpp
- src/tor/tor_process.cpp
This means the large legacy src/tor/ tree is mostly dormant from the wallet build's perspective.

Rebase target

Target upstream Tor line: 0.4.9.x
Imported source tree: src/tor/tor-src
Imported branch: release-0.4.9
Imported commit: 1442ca4

Why this matters

Attempting to "upgrade embedded Tor" by rebasing the entire old source tree in place is unnecessarily expensive if the wallet is only relying on:

process management for a bundled Tor executable
Tor v3 onion address/key handling
a few local embedding hooks

The migration should preserve the embedded product experience while reducing coupling to legacy upstream Tor internals.

Strategy

Keep the product-level embedding model.
- The wallet can still ship with Tor and launch it automatically.
Separate Triangles-owned glue from vendored Tor code.
- src/tor_embed_hooks.* now holds local process/bootstrap helpers that previously lived under src/tor/anonymize.*.
Treat src/tor/onion_v3.cpp and src/tor/tor_process.cpp as the active compatibility boundary.
Re-vendor a newer upstream Tor snapshot only after deciding whether the product truly needs upstream Tor source in-tree or only a bundled Tor runtime plus the wallet's own v3/onion management code.

Immediate next tasks

Audit whether any live build target still includes legacy src/tor/*.c sources beyond the current wallet target.
Decide whether onion_v3.cpp should remain wallet-owned code or be reduced further in favor of runtime Tor control/provisioning.
Add build metadata recording the intended upstream Tor version and source.
If full upstream vendoring is still required, import a fresh 0.4.8.19 tree side-by-side instead of trying to patch the legacy 0.2.5.1 tree.

2.2 KiB Raw Blame History