2ba0ecf428
Migration from boost to std-library equivalents and removal of unreachable code paths. Touches infrastructure only — no consensus rule or wallet serialization changes. Dead code removed: - IRC bootstrap (irc.cpp/h, 417 lines): orphan from pre-Tor era, no callers. - Alert system (alert.cpp/h + sendalert RPC + Qt UI signal, ~500 lines): retired post-V5 fork; old peers' alert messages now hit the unknown-cmd default branch, logged + ignored. - Legacy P2P handlers in main.cpp: "checkpoint" (already a no-op stub since V5 fork master-key removal), "checkorder"/"reply" (2010-era Receive-by-IP feature), plus their unused supporting structures (CRequestTracker, PushRequest overloads, mapRequests/cs_mapRequests, mapReuseKey). - Unreachable RPCs clearwallettransactions and scanforalltxns (~175 lines): defined in rpcwallet.cpp but never registered in the dispatch table. - Stale -alertnotify CLI help text (option was advertised but never wired). boost::filesystem -> std::filesystem (C++17): - 30 source files, 5 headers. namespace fs = boost::filesystem swapped to namespace fs = std::filesystem; boost::filesystem::ifstream/ofstream replaced with std::ifstream/ofstream (path-aware in C++17); fs::system_complete -> fs::absolute; boost::filesystem::filesystem_error -> std::filesystem::filesystem_error. - Build system: dropped Boost::filesystem from link libs and Boost components; PCH includes updated. - Added explicit <filesystem> includes where types were previously available only transitively (db.h, rpcblockchain.cpp). boost::thread -> std::thread (12 files): - sync.h CCriticalSection/CWaitableCriticalSection now alias std::recursive_mutex/std::mutex. boost::unique_lock and boost::condition_variable / boost::mutex::scoped_lock swapped to std equivalents; sync.cpp boost::thread_specific_ptr -> thread_local std::unique_ptr. - init.cpp boost::thread_group rewritten as std::vector<std::thread> with manual join loop. boost::thread::hardware_concurrency -> std::thread::hardware_concurrency. - main.cpp/wallet.cpp -blocknotify/-walletnotify shell-out threads now use std::thread(...).detach() — fixes a latent bug where modern boost::thread destructor would call std::terminate on the joinable thread. - util.cpp NewThread now catches std::system_error. - No interruption_point/interrupt usage anywhere — pure mechanical swap. boost::chrono / boost::posix_time -> std::chrono (3 of 5 files): - util.h: MilliSleep, GetTimeMillis, GetTimeMicros rewritten on std::chrono (system_clock for epoch math, sleep_for for delays). - snapshotnet.cpp: sleep_for swapped. - DoS_tests.cpp: timing harness uses steady_clock. - Skipped: rpcdump.cpp (boost::posix_time::time_input_facet has no clean std::get_time equivalent) and qt/qtipcserver.cpp (locked to boost::posix_time by boost::interprocess::message_queue::timed_receive). Other housekeeping: - Dropped unnecessary "using namespace boost;" from txdb-leveldb.cpp, txdb-rocksdb.cpp, walletdb.cpp, db.cpp (verified no unqualified boost names in those TUs). - Removed unused extern declaration for clearwallettransactions. Build fixes for non-unity builds on MinGW64/GCC 15: - net.cpp: dropped stale #include "irc.h". - addrman.cpp + main.cpp: explicit <cmath> include for sqrt/pow (was arriving transitively via boost headers). - rpcblockchain.cpp + init.cpp: defensive #undef STRICT/ADVISORY/PERMISSIVE since windows.h macros collide with the Checkpoints:: enum values when std headers reorder include flow. - tor_embed_hooks.cpp: triangles_tor_check_interrupted now polls fShutdown instead of boost::this_thread::interruption_requested (we never used boost interruption — the hook was always effectively a no-op). - snapshotnet.cpp: fs::remove error handle uses std::error_code. - serialize.h: added <ios> for std::ios::badbit/failbit (was relying on transitive include via boost). Note: unity builds currently fail on this branch due to std::byte (C++17) colliding with COM 'byte' typedef from shlobj.h when 'using namespace std;' from earlier files in the unity slice leaks into util.cpp's parse of shlobj.h. Build with -DENABLE_UNITY_BUILD=OFF (the default). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
299 lines
9.7 KiB
C++
299 lines
9.7 KiB
C++
//
|
|
// Unit tests for denial-of-service detection/prevention code
|
|
//
|
|
#include <algorithm>
|
|
|
|
#include <chrono>
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
#include "main.h"
|
|
#include "wallet.h"
|
|
#include "net.h"
|
|
#include "util.h"
|
|
|
|
#include <stdint.h>
|
|
|
|
// Tests this internal-to-main.cpp method:
|
|
extern bool AddOrphanTx(const CTransaction& tx);
|
|
extern unsigned int LimitOrphanTxSize(unsigned int nMaxOrphans);
|
|
extern std::map<uint256, CTransaction> mapOrphanTransactions;
|
|
extern std::map<uint256, std::set<uint256> > mapOrphanTransactionsByPrev;
|
|
|
|
CService ip(uint32_t i)
|
|
{
|
|
struct in_addr s;
|
|
s.s_addr = i;
|
|
return CService(CNetAddr(s), GetDefaultPort());
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE(DoS_tests)
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_banning)
|
|
{
|
|
CNode::ClearBanned();
|
|
CAddress addr1(ip(0xa0b0c001));
|
|
CNode dummyNode1(INVALID_SOCKET, addr1, "", true);
|
|
dummyNode1.Misbehaving(100); // Should get banned
|
|
BOOST_CHECK(CNode::IsBanned(addr1));
|
|
BOOST_CHECK(!CNode::IsBanned(ip(0xa0b0c001|0x0000ff00))); // Different IP, not banned
|
|
|
|
CAddress addr2(ip(0xa0b0c002));
|
|
CNode dummyNode2(INVALID_SOCKET, addr2, "", true);
|
|
dummyNode2.Misbehaving(50);
|
|
BOOST_CHECK(!CNode::IsBanned(addr2)); // 2 not banned yet...
|
|
BOOST_CHECK(CNode::IsBanned(addr1)); // ... but 1 still should be
|
|
dummyNode2.Misbehaving(50);
|
|
BOOST_CHECK(CNode::IsBanned(addr2));
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_banscore)
|
|
{
|
|
CNode::ClearBanned();
|
|
mapArgs["-banscore"] = "111"; // because 11 is my favorite number
|
|
CAddress addr1(ip(0xa0b0c001));
|
|
CNode dummyNode1(INVALID_SOCKET, addr1, "", true);
|
|
dummyNode1.Misbehaving(100);
|
|
BOOST_CHECK(!CNode::IsBanned(addr1));
|
|
dummyNode1.Misbehaving(10);
|
|
BOOST_CHECK(!CNode::IsBanned(addr1));
|
|
dummyNode1.Misbehaving(1);
|
|
BOOST_CHECK(CNode::IsBanned(addr1));
|
|
mapArgs.erase("-banscore");
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_bantime)
|
|
{
|
|
CNode::ClearBanned();
|
|
int64_t nStartTime = GetTime();
|
|
SetMockTime(nStartTime); // Overrides future calls to GetTime()
|
|
|
|
CAddress addr(ip(0xa0b0c001));
|
|
CNode dummyNode(INVALID_SOCKET, addr, "", true);
|
|
|
|
dummyNode.Misbehaving(100);
|
|
BOOST_CHECK(CNode::IsBanned(addr));
|
|
|
|
SetMockTime(nStartTime+60*60);
|
|
BOOST_CHECK(CNode::IsBanned(addr));
|
|
|
|
SetMockTime(nStartTime+60*60*24+1);
|
|
BOOST_CHECK(!CNode::IsBanned(addr));
|
|
}
|
|
|
|
static bool CheckNBits(unsigned int nbits1, int64_t time1, unsigned int nbits2, int64_t time2)\
|
|
{
|
|
if (time1 > time2)
|
|
return CheckNBits(nbits2, time2, nbits1, time1);
|
|
int64_t deltaTime = time2-time1;
|
|
|
|
CBigNum required;
|
|
required.SetCompact(ComputeMinWork(nbits1, deltaTime));
|
|
CBigNum have;
|
|
have.SetCompact(nbits2);
|
|
return (have <= required);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_checknbits)
|
|
{
|
|
// Timestamps,nBits from the Triangles blockchain.
|
|
// These are the block-chain checkpoint blocks
|
|
typedef std::map<int64_t, unsigned int> BlockData;
|
|
BlockData chainData = {
|
|
{1239852051,486604799},{1262749024,486594666},
|
|
{1279305360,469854461},{1280200847,469830746},{1281678674,469809688},
|
|
{1296207707,453179945},{1302624061,453036989},{1309640330,437004818},
|
|
{1313172719,436789733},
|
|
};
|
|
|
|
// Make sure CheckNBits considers every combination of block-chain-lock-in-points
|
|
// "sane":
|
|
for (const BlockData::value_type& i : chainData)
|
|
{
|
|
for (const BlockData::value_type& j : chainData)
|
|
{
|
|
BOOST_CHECK(CheckNBits(i.second, i.first, j.second, j.first));
|
|
}
|
|
}
|
|
|
|
// Test a couple of insane combinations:
|
|
BlockData::value_type firstcheck = *(chainData.begin());
|
|
BlockData::value_type lastcheck = *(chainData.rbegin());
|
|
|
|
// First checkpoint difficulty at or a while after the last checkpoint time should fail when
|
|
// compared to last checkpoint
|
|
BOOST_CHECK(!CheckNBits(firstcheck.second, lastcheck.first+60*10, lastcheck.second, lastcheck.first));
|
|
BOOST_CHECK(!CheckNBits(firstcheck.second, lastcheck.first+60*60*24*14, lastcheck.second, lastcheck.first));
|
|
|
|
// ... but OK if enough time passed for difficulty to adjust downward:
|
|
BOOST_CHECK(CheckNBits(firstcheck.second, lastcheck.first+60*60*24*365*4, lastcheck.second, lastcheck.first));
|
|
|
|
}
|
|
|
|
CTransaction RandomOrphan()
|
|
{
|
|
std::map<uint256, CTransaction>::iterator it;
|
|
it = mapOrphanTransactions.lower_bound(GetRandHash());
|
|
if (it == mapOrphanTransactions.end())
|
|
it = mapOrphanTransactions.begin();
|
|
return it->second;
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_mapOrphans)
|
|
{
|
|
CKey key;
|
|
key.MakeNewKey(true);
|
|
CBasicKeyStore keystore;
|
|
keystore.AddKey(key);
|
|
|
|
// 50 orphan transactions:
|
|
for (int i = 0; i < 50; i++)
|
|
{
|
|
CTransaction tx;
|
|
tx.vin.resize(1);
|
|
tx.vin[0].prevout.n = 0;
|
|
tx.vin[0].prevout.hash = GetRandHash();
|
|
tx.vin[0].scriptSig << OP_1;
|
|
tx.vout.resize(1);
|
|
tx.vout[0].nValue = 1*CENT;
|
|
tx.vout[0].scriptPubKey.SetDestination(key.GetPubKey().GetID());
|
|
|
|
AddOrphanTx(tx);
|
|
}
|
|
|
|
// ... and 50 that depend on other orphans:
|
|
for (int i = 0; i < 50; i++)
|
|
{
|
|
CTransaction txPrev = RandomOrphan();
|
|
|
|
CTransaction tx;
|
|
tx.vin.resize(1);
|
|
tx.vin[0].prevout.n = 0;
|
|
tx.vin[0].prevout.hash = txPrev.GetHash();
|
|
tx.vout.resize(1);
|
|
tx.vout[0].nValue = 1*CENT;
|
|
tx.vout[0].scriptPubKey.SetDestination(key.GetPubKey().GetID());
|
|
SignSignature(keystore, txPrev, tx, 0);
|
|
|
|
AddOrphanTx(tx);
|
|
}
|
|
|
|
// This really-big orphan should be ignored:
|
|
for (int i = 0; i < 10; i++)
|
|
{
|
|
CTransaction txPrev = RandomOrphan();
|
|
|
|
CTransaction tx;
|
|
tx.vout.resize(1);
|
|
tx.vout[0].nValue = 1*CENT;
|
|
tx.vout[0].scriptPubKey.SetDestination(key.GetPubKey().GetID());
|
|
tx.vin.resize(500);
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++)
|
|
{
|
|
tx.vin[j].prevout.n = j;
|
|
tx.vin[j].prevout.hash = txPrev.GetHash();
|
|
}
|
|
SignSignature(keystore, txPrev, tx, 0);
|
|
// Re-use same signature for other inputs
|
|
// (they don't have to be valid for this test)
|
|
for (unsigned int j = 1; j < tx.vin.size(); j++)
|
|
tx.vin[j].scriptSig = tx.vin[0].scriptSig;
|
|
|
|
BOOST_CHECK(!AddOrphanTx(tx));
|
|
}
|
|
|
|
// Test LimitOrphanTxSize() function:
|
|
LimitOrphanTxSize(40);
|
|
BOOST_CHECK(mapOrphanTransactions.size() <= 40);
|
|
LimitOrphanTxSize(10);
|
|
BOOST_CHECK(mapOrphanTransactions.size() <= 10);
|
|
LimitOrphanTxSize(0);
|
|
BOOST_CHECK(mapOrphanTransactions.empty());
|
|
BOOST_CHECK(mapOrphanTransactionsByPrev.empty());
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(DoS_checkSig)
|
|
{
|
|
// Test signature caching code (see key.cpp Verify() methods)
|
|
|
|
CKey key;
|
|
key.MakeNewKey(true);
|
|
CBasicKeyStore keystore;
|
|
keystore.AddKey(key);
|
|
|
|
// 100 orphan transactions:
|
|
static const int NPREV=100;
|
|
CTransaction orphans[NPREV];
|
|
for (int i = 0; i < NPREV; i++)
|
|
{
|
|
CTransaction& tx = orphans[i];
|
|
tx.vin.resize(1);
|
|
tx.vin[0].prevout.n = 0;
|
|
tx.vin[0].prevout.hash = GetRandHash();
|
|
tx.vin[0].scriptSig << OP_1;
|
|
tx.vout.resize(1);
|
|
tx.vout[0].nValue = 1*CENT;
|
|
tx.vout[0].scriptPubKey.SetDestination(key.GetPubKey().GetID());
|
|
|
|
AddOrphanTx(tx);
|
|
}
|
|
|
|
// Create a transaction that depends on orphans:
|
|
CTransaction tx;
|
|
tx.vout.resize(1);
|
|
tx.vout[0].nValue = 1*CENT;
|
|
tx.vout[0].scriptPubKey.SetDestination(key.GetPubKey().GetID());
|
|
tx.vin.resize(NPREV);
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++)
|
|
{
|
|
tx.vin[j].prevout.n = 0;
|
|
tx.vin[j].prevout.hash = orphans[j].GetHash();
|
|
}
|
|
// Creating signatures primes the cache:
|
|
auto mst1 = std::chrono::steady_clock::now();
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++)
|
|
BOOST_CHECK(SignSignature(keystore, orphans[j], tx, j));
|
|
auto mst2 = std::chrono::steady_clock::now();
|
|
long nOneValidate = std::chrono::duration_cast<std::chrono::milliseconds>(mst2 - mst1).count();
|
|
if (fDebug) printf("DoS_Checksig sign: %ld\n", nOneValidate);
|
|
|
|
// ... now validating repeatedly should be quick:
|
|
// 2.8GHz machine, -g build: Sign takes ~760ms,
|
|
// uncached Verify takes ~250ms, cached Verify takes ~50ms
|
|
// (for 100 single-signature inputs)
|
|
mst1 = std::chrono::steady_clock::now();
|
|
for (unsigned int i = 0; i < 5; i++)
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++)
|
|
BOOST_CHECK(VerifySignature(orphans[j], tx, j, SIGHASH_ALL));
|
|
mst2 = std::chrono::steady_clock::now();
|
|
long nManyValidate = std::chrono::duration_cast<std::chrono::milliseconds>(mst2 - mst1).count();
|
|
if (fDebug) printf("DoS_Checksig five: %ld\n", nManyValidate);
|
|
|
|
BOOST_CHECK_MESSAGE(nManyValidate < nOneValidate, "Signature cache timing failed");
|
|
|
|
// Empty a signature, validation should fail:
|
|
CScript save = tx.vin[0].scriptSig;
|
|
tx.vin[0].scriptSig = CScript();
|
|
BOOST_CHECK(!VerifySignature(orphans[0], tx, 0, SIGHASH_ALL));
|
|
tx.vin[0].scriptSig = save;
|
|
|
|
// Swap signatures, validation should fail:
|
|
std::swap(tx.vin[0].scriptSig, tx.vin[1].scriptSig);
|
|
BOOST_CHECK(!VerifySignature(orphans[0], tx, 0, SIGHASH_ALL));
|
|
BOOST_CHECK(!VerifySignature(orphans[1], tx, 1, SIGHASH_ALL));
|
|
std::swap(tx.vin[0].scriptSig, tx.vin[1].scriptSig);
|
|
|
|
// Exercise -maxsigcachesize code:
|
|
mapArgs["-maxsigcachesize"] = "10";
|
|
// Generate a new, different signature for vin[0] to trigger cache clear:
|
|
CScript oldSig = tx.vin[0].scriptSig;
|
|
BOOST_CHECK(SignSignature(keystore, orphans[0], tx, 0));
|
|
BOOST_CHECK(tx.vin[0].scriptSig != oldSig);
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++)
|
|
BOOST_CHECK(VerifySignature(orphans[j], tx, j, SIGHASH_ALL));
|
|
mapArgs.erase("-maxsigcachesize");
|
|
|
|
LimitOrphanTxSize(0);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|