7 Commits

Author	SHA1	Message	Date
SamiAhmed7777	9a50ab3b2e	Expand script.cpp test coverage: libFuzzer harness + EvalScript stress tests + UBSan fix (#27) ... * simd: fix UBSan signed-shift UB in fft64 INNER macro The INNER macro at src/simd.c:379 combines the low and high halves of two FFT values with a multiplier: ((u32)((l) * (mm)) & 0xFFFFU) + ((u32)((h) * (mm)) << 16) When (h)*(mm) is a negative s32, the (u32) cast recovers the bit pattern (large positive number), but then << 16 operates on the integer-promoted value (typically int on x86_64). UBSan flags this as signed-shift of negative. Fix: explicit (u32) cast inside the shift expression forces the shift operand to unsigned (well-defined per C++20). Outer (u32) cast keeps the result type consistent. Bit-equivalent at runtime; type-safe for UBSan. Mirrors the pattern Krystie applied in b9d06d5 for the same issue in FFT8/FFT16 macros. Could not reproduce the trip in a standalone 100-trial test (Hash9's specific call pattern from CBlock::GetHash may not be reproducible in isolation), but the macro is the same UB class as already-fixed sites — fix by inspection per the triangles-test-suite-audit skill. Build verified: ninja test_triangles clean, all 234 test cases + 21720 assertions pass under sanitizers. Tests exercise Hash9 via TestingSetup, so the FFT path is covered. * test: add libFuzzer harness + EvalScript stress tests + CI fuzz job Three pieces, one goal: expand coverage of script.cpp (the consensus-critical opcode interpreter) beyond what Boost unit tests catch. 1. libFuzzer harness (src/test/fuzz/) Builds against the existing daemon object files (init.cpp.o, wallet.cpp.o, noui.cpp.o) so we get the full CWallet vtable without writing 100+ lines of fragile method stubs. Link line reuses the sanitizer-friendly flags from test-linux-sanitizers. Corpus seeded from src/test/data/script_{valid,invalid}.json (1055 real Triangles scripts). BUILD_FUZZ is OFF by default — gcc default build doesn't have libFuzzer, so the flag gates the custom clang++ build cleanly. 2. Stress tests (src/test/script_stress_tests.cpp) Six regression-guard tests for EvalScript's hard limits. Anyone who removes a bound will get a test failure: - deep_dup_stack_hits_opcount_limit — 250 OP_DUP rejected <1s - max_keys_multisig_20_of_20 — 20-of-20 terminates <2s - multisig_rejects_21_keys — nKeysCount > 20 rejected - pushdata_over_520_rejected — MAX_SCRIPT_ELEMENT_SIZE - script_size_over_10000_rejected — MAX_SCRIPT_SIZE - disabled_opcodes_rejected — all 15 disabled opcodes EvalScript contract caveat (captured in the test comments): on false return, the stack is left dirty — inputs pushed before rejection are still there. Tests assert stack.size() <= N for N = number of inputs pushed, not the post-opcode expectation. 3. CI fuzz job (.github/workflows/build-all.yml) test-fuzz-smoke job, sibling of test-linux-sanitizers. Reuses the same runner + apt-get + RocksDB-from-source + Tor-from-source steps so CI runtime doesn't double. Builds with clang-15, ASan+UBSan+libFuzzer, seeds corpus, runs 5 minutes, fails only on crash artifact (not on find_new_units=0 — libFuzzer always writes .tmp churn during normal operation). Verified: - ninja test_triangles clean - 234/234 test cases + 21720/21720 assertions pass - 4/4 ctest suites pass (triangles_unit + chaindb_equivalence + snapshotnet + chaindb_runtime) - Local fuzz run: 8354 corpus files, ~5400 exec/sec, zero crashes after several hours (-jobs=2 -workers=2) * build: explicit <cassert> in allocators.h clang's stricter include resolution surfaces the missing include even though gcc tolerates it via some other transitive path. Without this, PR #27 build with clang fails on assert() in LockedPageManager. * fix(ci,fuzz): unbreak test-fuzz-smoke workflow + CMake fuzz link deps Three bugs in PR #27's fuzz smoke integration that CI caught on first run: 1. CMAKE_EXE_LINKER_FLAGS pulled in '-fsanitize=fuzzer $SAN_FLAGS'. CMake's compiler-probe linker test (used to verify the toolchain) doesn't define LLVMFuzzerTestOneInput, so adding -fsanitize=fuzzer pulls in libclang_rt.fuzzer's main() and trips 'multiple definition of `main`'. Remove -fsanitize=fuzzer from global flags; fuzz_script already adds it per-target via FUZZ_COMMON_FLAGS in src/CMakeLists.txt. 2. Workflow said --target script_fuzz / ./build-fuzz/bin/script_fuzz, but the CMake target is fuzz_script (add_custom_target(fuzz_script ...)). CI failed with 'unknown target'. Fixed in workflow + comment. 3. fuzz_script link references static libs at ${CMAKE_BINARY_DIR}/lib/ (libhash9_crypto.a, libleveldb_lib.a, libleveldb_memenv.a, libsecp256k1.a) but didn't declare them as DEPENDS. First clean build races the link step and fails with 'no such file or directory'. Added the four static library targets to DEPENDS so ninja builds them first. Verified locally: cmake configure clean, fuzz_script link succeeds, binary runs (./bin/fuzz_script prints libFuzzer banner and reads corpus). Tested with the same flag set CI uses (SAN_FLAGS with fuzzer-no-link, BUILD_FUZZ=ON, clang-14). * fix(ci,fuzz): make test-fuzz-smoke work end-to-end on clean builds Three more bugs in PR #27's fuzz integration, caught on local repro after commit 3239425 fixed the easy ones: 1. clang vs gcc warning mismatch (cmake/AddCompilerFlags.cmake): gcc treats -Wreserved-user-defined-literal as a warning. clang-15+ in C++20 mode promotes it to an error and trips on hundreds of Bitcoin-derived sites like strprintf("%"PRId64...) in util.cpp / kernel.cpp. Conditional -Wno-reserved-user-defined-literal scoped to clang only — gcc builds keep the original diagnostic. 2. secp256k1 ASM strictness (.github/workflows/build-all.yml): Add -DSECP256K1_ASM=OFF to the fuzz configure. Clang-15+'s register allocator is sometimes stricter than clang-14 about the x86_64 inline asm in scalar_4x64_impl.h and fails with 'inline assembly requires more registers than available'. The fuzz target only needs ECC at the C-fallback level — slower but correct. 3. Empty .o glob at link time (src/CMakeLists.txt): The fuzz link line referenced CMakeFiles/triangles_common.dir/*.o and CMakeFiles/trianglesd.dir/*.o via file(GLOB), which evaluates at cmake CONFIGURE time. On a fresh build dir, no .o files exist yet → the link line was always empty → undefined references for CKey::GetPubKey, typeinfo for CKeyStore, etc. Replace the GLOB with a generated bash wrapper script (fuzz_objs/link.sh) that does the find at link time, using bash arrays to safely handle paths with spaces. The script is invoked via ninja with the original link line as its argv; it prepends the discovered .o files (excluding script.cpp.o — we have our own clang-instrumented copy in fuzz_objs/) and exec's clang++. Verified locally: - cmake configures cleanly under clang-18 with the same flag set CI uses - ninja fuzz_script links end-to-end (132 MB ELF, debug info, all sanitizer coverage instrumentation intact) - ./bin/fuzz_script runs and discovers coverage: 'INITED cov: 3 ft: 3 corp: 1/1b' from libFuzzer banner - 4/4 ctest suites still pass on the gcc build (master chaindb / snapshotnet / unit / equivalence) This should make test-fuzz-smoke pass on the next CI run. * fix(ci,fuzz): stabilize fuzz smoke job * fix(ci,fuzz): portable fuzz build, exclude daemon main, stub globals - Build daemon (init/wallet/noui) as an OBJECT library under BUILD_FUZZ so the fuzz job does not pay the daemon executable link cost. - Exclude init.cpp.o from the fuzz link wrapper (it defines the daemon's main(), conflicting with libFuzzer's own). - Replace hardcoded libboost/librocksdb filenames with -l flags and Boost target paths resolved at configure time. - Add -lubsan to the fuzz link line so libstdc++'s ubsan hooks resolve. - Add a generated fuzz_stubs.cpp that defines pwalletMain, uiInterface, CheckpointsMode, nNodeLifespan, etc. — every global that init.cpp used to provide. - Keep the CI workflow's libtor build step (fuzz links libtor.a). Local verify: clang-15 + clang-18 + gcc all build fuzz_script; 15s fuzz run completes 1913 execs with no crash artifacts; gcc test build passes 4/4 ctest suites unchanged. * fix(ci,fuzz): drop libi2pd*.a paths from fuzz link line The fuzz job in build-all.yml runs libtor.sh but NOT libi2pd.sh, so src/i2p/i2pd-src/libi2pd{,client,lang}.a don't exist on the CI runner. The previous commit (720d711) hardcoded them into the fuzz link line; the link failed with clang: error: no such file or directory: '.../i2p/i2pd-src/libi2pd*.a' i2p_embedded.cpp is already compiled into triangles_common, and with USE_I2P_EMBEDDED=OFF (the CI default) the only i2p surface is the no-op stub in triangles_common. So the .a references were both wrong AND redundant. Keep libtor.a: src/tor/build-libtor.sh IS run in the fuzz job, so the file exists when the link wrapper invokes clang++. Verified locally with clang-15 against the same cmake flags the workflow uses: clean link, 12s fuzz run did 1239 executions, no crash artifacts, libFuzzer reporting normal coverage growth. * fix(ci,fuzz): install libgflags-dev for fuzz smoke job CI failure on PR #27 test-fuzz-smoke: link step aborted with `/usr/bin/ld: cannot find -lgflags`. The fuzz link line in src/CMakeLists.txt references -lgflags (transitive dep of RocksDB), and CI's ubuntu-22.04 runner does NOT ship libgflags-dev. DNS2 ships libgflags-dev as an automatic dep of build-essential, which is why local dry-runs didn't catch this. Verified locally on DNS2: - Cloned the exact CI cmake invocation (build-fuzz-verify dir) - cmake -B + cmake --build --target fuzz_script: clean build - 30s fuzz pass: 1058 inputs, 1935 features covered, no crashes The libtor build step also depends on gflags transitively; making it explicit in the apt-get list future-proofs both paths. * fix(ci,fuzz): link -lrocksdb unconditionally in fuzz target CI's test-fuzz-smoke job was failing with a torrent of `undefined reference to rocksdb::Status::ToString[abi:cxx11]()` errors after the libgflags fix landed. The fuzz target's RocksDB link arg was: $<IF:$<TARGET_EXISTS:RocksDB::rocksdb>,-lrocksdb,${ROCKSDB_LIBRARY}> That generator expression was wrong on CI's exact code path: 1. CMake's `find_package(RocksDB CONFIG)` does NOT find the .cmake config RocksDB 8.9.1 ships — only the .pc file. 2. `pkg_check_modules(RocksDB IMPORTED_TARGET)` therefore exposes `PkgConfig::RocksDB` (NOT `RocksDB::rocksdb`), so $<TARGET_EXISTS:RocksDB::rocksdb> is FALSE. 3. The fallback ${ROCKSDB_LIBRARY} is set ONLY inside the manual `find_library()` probe at top-level CMakeLists.txt:170-190, which is skipped when EITHER `RocksDB::rocksdb` or `PkgConfig::RocksDB` already exists. Result on CI: an empty string landed in the link line, so the link step saw no `-lrocksdb` arg and every RocksDB symbol the fuzz binary referenced became undefined. Fix: just use a bare `-lrocksdb` and let the library search path do the work. `build-rocksdb.sh` installs to /usr/local/lib (CI); `librocksdb-dev` (apt) installs to /usr/lib/x86_64-linux-gnu (DNS2). Both paths are in the default search path. Verified locally on DNS2 with the exact CI cmake invocation + flags: - build-fuzz-verify2: clean build, exit 0 - 20s fuzz pass: 1548 inputs, 2024 features covered, no crashes Co-located with the libgflags fix on feat/script-fuzz-and-stress-tests because both fixes are required for test-fuzz-smoke to turn green. --------- Co-authored-by: Sami Ahmed <sami@sami-ahmed.net>	2026-07-11 16:02:35 -07:00
sami7777	5635cb5e57	build: enforce -march=x86-64-v2 on Linux x86_64 ... GCC 11+ on Intel CI runners (Skylake-X, Ice Lake, Sapphire Rapids) emits AVX-512/AVX10 instructions for std::string / memcpy inlining that crash with SIGILL on AMD EPYC and older Intel without those extensions. Root cause: libstdc++ is statically linked into the binary, so the build host's instruction set becomes a hard runtime requirement. The CI binary crashed immediately on DNS2/DNS3 (AMD EPYC Milan) with: traps: trianglesd[...] trap invalid opcode ip:...e432 error:0 in trianglesd[...+af3000] Disassembly of the crash site (file offset 0x15b432): 62 f1 7f 08 6f 41 ff vmovdqu8 -0x10(%rcx), %xmm0 This is an AVX10/AVX-512 instruction emitted inside std::basic_string::basic_string (statically linked libstdc++). Fix: -march=x86-64-v2 -mtune=generic for all Linux x86_64 builds. v2 baseline (SSE4.2 + POPCNT + CMPXCHG16B) is from 2009 Nehalem and supported on every x86_64 CPU we ship to. Override-able via -DCMAKE_X86_64_BASELINE=OFF if a CPU-specific build is needed.	2026-07-01 03:26:31 -07:00
Krystie	53f003aef1	v5.9.24: update TRI home + explorer links, networking fixes, checkpoint publisher ... - qt: TRI home → https://cryptographic-triangles.org/ (UI + 65 locales) - qt: block explorer → https://blocks.cryptographic-triangles.org (65 locales) - net: networking hardening + checkpoint publisher support - build: MinGW cross-compilation toolchain, CI tridock rebuild trigger - test: checkpoint publisher + onion v3 test updates - test: chaindb equivalence test suite (LevelDB↔RocksDB migration parity) - util: expose ResetDataDirCache() for test fixture datadir switching - txdb: WriteRawPublic/ReadRawPublic test seam for raw byte-level access - version bump 5.9.23 → 5.9.24	2026-06-23 20:13:02 -07:00
sami7777	25475d1057	Fix C++20 build: allocators + bundled LevelDB ... C++20 broke two things in the prior bump: 1. std::allocator no longer exposes pointer/const_pointer/reference/ const_reference member typedefs, and the 2-arg allocate(n, hint) was removed. Both secure_allocator and zero_after_free_allocator inherited these from std::allocator. Define the typedefs ourselves and switch the secure_allocator allocate() to the single-arg form. 2. Bundled src/leveldb uses `std::memory_order::memory_order_relaxed` which was valid in C++17 but became a hard error in C++20 (memory_order is now a scoped enum class — the values are at namespace scope or memory_order::relaxed, not memory_order::memory_order_relaxed). LevelDB itself only needs C++11, so pin its targets to C++17 in BuildLevelDB.cmake instead of patching vendored code. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-26 18:34:38 -07:00
sami7777	7d62e34868	Harden network security, fix moneysupply tracking, version system overhaul (v5.8.0) ... - Fix moneysupply calculation in FastImportBlockFile and ConnectBlock assumevalid path - Route bootstrap downloads through Tor SOCKS proxy (no more clearnet leaks) - Remove hardcoded clearnet fallback IP from bootstrap - Fix snprintf missing argument in walletmodel.cpp narration key (UB/crash) - Fix potential null deref from db_strerror() in rpcwallet.cpp - Filter non-.onion addresses from HTTPS seed list parser - Add periodic re-seeding when node has 0 outbound peers - Make clientversion.h single source of truth for version display string - Remove redundant DISPLAY_VERSION macros from version.h - Update README: max supply 2,222,222, CMake build instructions, Tor-only config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-12 19:26:12 -07:00
sami7777	104778fa61	Fix macOS build: restrict -z relro/now to Linux only ... The -Wl,-z,relro and -Wl,-z,now flags are ELF-specific and not supported by macOS's linker. Guard them with if(NOT APPLE). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-05 04:04:48 -07:00
sami7777	1bcaf6b615	Migrate build system from qmake/makefiles to CMake ... Remove legacy build files (Makefile, makefile.unix/mingw/osx, triangles-qt.pro) and replace with CMake build system. Includes find modules for all dependencies, LevelDB bundled build, and updated CI workflow for CMake + Ninja on all platforms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-05 02:00:58 -07:00