From db77184277d080eb00e22bce7c6e1330d43198d0 Mon Sep 17 00:00:00 2001 From: Sami Ahmed Date: Sat, 4 Apr 2026 00:33:59 -0700 Subject: [PATCH] Fix CI: test_GetThrow for UTXO model, install unzip for inetc - transaction_tests: AreInputsStandard returns false (not throw) for missing inputs - build-all.yml: install unzip package before extracting inetc plugin Co-Authored-By: Claude Opus 4.6 --- .github/workflows/build-all.yml | 1 + src/test/transaction_tests.cpp | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-all.yml b/.github/workflows/build-all.yml index 224d50e..34f2104 100644 --- a/.github/workflows/build-all.yml +++ b/.github/workflows/build-all.yml @@ -166,6 +166,7 @@ jobs: - name: Install NSIS inetc plugin run: | + pacman -S --noconfirm unzip NSIS_DIR="/mingw64/share/nsis" cd /tmp curl -L -o Inetc.zip "https://nsis.sourceforge.io/mediawiki/images/c/c9/Inetc.zip" diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 24a8665..6ee4d15 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -152,7 +152,8 @@ BOOST_AUTO_TEST_CASE(test_GetThrow) t1.vout[0].nValue = 90*CENT; t1.vout[0].scriptPubKey << OP_1; - BOOST_CHECK_THROW(t1.AreInputsStandard(missingInputs), runtime_error); + // AreInputsStandard returns false for missing inputs (no longer throws) + BOOST_CHECK(!t1.AreInputsStandard(missingInputs)); BOOST_CHECK_THROW(t1.GetValueIn(missingInputs), runtime_error); }