sami7777/triangles_v5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: tolerate 1-unit truncation rounding in PoS reward proportionality

Browse Source 
After reverting the consensus-affecting PoS reward rework, the original
truncating formula (nCoinAge * rate / 365 / COIN) is restored. It is not
exactly proportional at every boundary (r2 can be 2*r1 +/- 1 due to integer
truncation). That rounding is the on-chain behavior and must not be changed
in consensus code, so relax pos_reward_proportional_to_coinage to allow a
1-unit difference rather than demanding exact doubling. Test-only change.
This commit is contained in:
Krystie
2026-07-04 15:08:21 -07:00
parent 05b56060ab
commit a78a420d76
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/staking_tests.cpp
+13 -2
View File
@@ -122,11 +122,22 @@ BOOST_AUTO_TEST_CASE(stake_modifier_checkpoints_testnet_always_passes)
BOOST_AUTO_TEST_CASE(pos_reward_proportional_to_coinage)
{
// Double the coin age should give double the reward
// Doubling the coin age roughly doubles the reward. The consensus
// formula GetProofOfStakeReward uses integer TRUNCATING division
// (nCoinAge * rate / 365 / COIN), so exact doubling does not hold at
// every boundary: e.g. r1 = 90410 but r2 = 180821 = 2*r1 + 1, because
// the /365 truncation lands one unit differently. That 1-unit rounding
// is the on-chain behavior; "fixing" it in consensus code would change
// emission and hard-fork the network, so the test tolerates a 1-unit
// difference instead.
int64_t r1 = GetProofOfStakeReward(100 * COIN, 0);
int64_t r2 = GetProofOfStakeReward(200 * COIN, 0);
BOOST_CHECK_EQUAL(r2, r1 * 2);
int64_t diff = r2 - r1 * 2;
if (diff < 0) diff = -diff;
BOOST_CHECK_MESSAGE(diff <= 1,
strprintf("reward not ~proportional: r1=%d r2=%d diff=%d", r1, r2, diff));
BOOST_CHECK(r1 > 0 && r2 > 0);
}
BOOST_AUTO_TEST_CASE(pos_reward_large_coinage)