sami7777/triangles_v5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cli): -conf= (empty value) falls back to default conf path

Browse Source 
Round-8 Codex review found this NIT-1 regression. When the user passes
-conf= with no value, mapArgs["-conf"] is "". Without a guard,
GetConfigFilePath() appended the empty string to the datadir, producing
a directory path like /root/.cryptographic-triangles/. std::ifstream
opens that as a directory successfully on Linux, then readConfigFile's
getline finds no lines, and the error path mis-reported 'missing BOTH
rpcuser/rpcpassword' for a file we never actually read.

Treat empty -conf as 'use default name' so the conf lookup at the
default datadir works the same as if no -conf was passed at all.
This commit is contained in:
Sami Ahmed
2026-07-18 01:39:44 -07:00
parent 64556dc8e7
commit 41e3898ff8
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/triangles-cli.cpp
+11
View File
@@ -169,6 +169,17 @@ static fs::path GetDefaultDataDir()
static fs::path GetConfigFilePath()
{
fs::path confPath = GetArg("-conf", "triangles.conf");
// Bug fix (round-8 NIT-1): if the user passed `-conf=` with no value
// (shell-quoting accident, env-var unset, or copy-paste template),
// mapArgs["-conf"] is "". Without this guard, we'd append an empty
// string to the datadir and produce a directory path like
// "/root/.cryptographic-triangles/" — std::ifstream opens that as a
// directory successfully on Linux, then readConfigFile's getline
// finds no lines and the error path mis-reports "missing BOTH
// rpcuser/rpcpassword" for a file we never actually read.
// Treat empty -conf as "use default name" so the conf lookup at the
// default datadir works the same as if no -conf was passed at all.
if (confPath.empty()) confPath = "triangles.conf";
if (confPath.is_absolute()) return confPath;
fs::path datadir = GetArg("-datadir", "");
if (datadir.empty()) datadir = GetDefaultDataDir().string();