sami7777/nyc3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
51e5ef3971c78f0aceb7e958c07f5e6cde224db0
nyc3/src
T
History
Wladimir J. van der Laan 51e5ef3971 Merge #14377: check that a separator is found for psbt inputs, outputs, and global map 
4fb3388db9 check that a separator is found for psbt inputs, outputs, and global map (Andrew Chow)

Pull request description:

  Currently it doesn't make sure that a separator was found so PSBTs missing a trailing separator would still pass. This fixes that and adds a test case for it.

  It really only makes sense to check for the separator for the output maps as if an input or global map was missing a separator, the fields following it would be interpreted as belonging to the previous input or global map. However I have added the check for those two anyways to be consistent.

Tree-SHA512: 50c0c08e201ba02494b369a4d36ddb73e6634eb5a4e4e201c4ef38fd2dbeea2c642b8a04d50c91615da61ecbfade37309e47431368f4b1064539c42015766b50
2018-11-01 17:55:39 +01:00
..
bench
Don't access out of bounds array entry array[sizeof(array)]
2018-10-05 16:48:16 +09:00
compat
Merge #13665: [build] Add risc-v support to gitian
2018-08-16 20:33:50 +02:00
config
…
consensus
Drop unused GetType() from CSizeComputer
2018-09-11 00:58:05 -04:00
crypto
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
index
Add compile time checking for cs_main locks which we assert at run time
2018-10-10 11:28:43 +02:00
interfaces
Merge #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet
2018-10-24 05:01:29 -04:00
leveldb
Merge leveldb subtree
2018-08-09 11:31:45 -04:00
obj
…
obj-test
…
policy
doxygen: Fix member comments
2018-09-26 15:42:21 -04:00
primitives
Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
2018-10-18 23:14:20 +02:00
qt
Merge #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support
2018-10-24 16:29:50 +02:00
rpc
Bugfix: RPC: Add address_type named param for createmultisig
2018-10-28 22:42:36 +00:00
script
Merge #14377: check that a separator is found for psbt inputs, outputs, and global map
2018-11-01 17:55:39 +01:00
secp256k1
…
support
Fix typos reported by codespell
2018-09-04 13:11:26 +02:00
test
Merge #13783: validation: Pass tx pool reference into CheckSequenceLocks
2018-10-27 10:39:44 -04:00
univalue
Update univalue subtree
2018-09-07 08:21:14 -04:00
wallet
Merge #14454: Add SegWit support to importmulti
2018-10-31 17:44:31 +01:00
zmq
[depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions
2018-09-11 16:33:05 -04:00
.clang-format
Fix inconsistent namespace formatting guidelines
2018-04-13 15:37:20 -04:00
addrdb.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
addrdb.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
addrman.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
addrman.h
Merge #13115: addrman: Add Clang thread safety annotations for variables guarded by CAddrMan.cs
2018-10-09 00:54:30 -03:00
amount.h
amount: Move CAmount CENT to unit test header
2018-09-17 14:34:56 -04:00
arith_uint256.cpp
Avoid triggering undefined behaviour in base_uint<BITS>::bits()
2018-10-18 11:17:05 +02:00
arith_uint256.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
base58.cpp
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)
2018-10-26 19:42:58 +02:00
base58.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
bech32.cpp
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-08-27 18:19:33 +02:00
bech32.h
Fix missing or inconsistent include guards
2018-03-22 16:23:04 +01:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
utils: Convert Windows args to utf-8 string
2018-09-30 15:08:16 +08:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
bitcoin-tx: Use constant for n pubkeys check
2018-10-13 10:55:51 +01:00
bitcoind-res.rc
…
bitcoind.cpp
utils: Convert Windows args to utf-8 string
2018-09-30 15:08:16 +08:00
blockencodings.cpp
Drop unused GetType() from CSizeComputer
2018-09-11 00:58:05 -04:00
blockencodings.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
blockfilter.cpp
blockfilter: Omit empty scripts from filter contents.
2018-08-28 12:12:32 -07:00
blockfilter.h
blockfilter: Additional helper methods to compute hash and header.
2018-08-25 10:02:37 -07:00
bloom.cpp
Merge #13429: Return the script type from Solver
2018-08-25 17:41:00 +02:00
bloom.h
Removes unsed CBloomFilter constructor.
2018-08-13 01:24:55 +02:00
chain.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
chain.h
[trivial] Fix typo in CDiskBlockPos struct's ToString
2018-08-14 18:03:43 -05:00
chainparams.cpp
Don't edit Chainparams after initialization
2018-09-23 22:58:54 +02:00
chainparams.h
Don't edit Chainparams after initialization
2018-09-23 22:58:54 +02:00
chainparamsbase.cpp
Don't edit Chainparams after initialization
2018-09-23 22:58:54 +02:00
chainparamsbase.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
chainparamsseeds.h
net: Update hardcoded seeds
2018-08-13 13:57:15 +02:00
checkpoints.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
checkpoints.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
checkqueue.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
clientversion.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
clientversion.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
coins.cpp
Drop unused GetType() from CSizeComputer
2018-09-11 00:58:05 -04:00
coins.h
Preserve a format of RPC command definitions
2018-08-20 15:19:12 +02:00
compat.h
Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5
2018-08-23 10:38:59 -07:00
compressor.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
compressor.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
core_io.h
Consolidate redundant implementations of ParseHashStr
2018-09-25 09:14:52 -07:00
core_memusage.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
core_read.cpp
Consolidate redundant implementations of ParseHashStr
2018-09-25 09:14:52 -07:00
core_write.cpp
Drop unused GetType() from CSizeComputer
2018-09-11 00:58:05 -04:00
cuckoocache.h
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-08-27 18:19:33 +02:00
dbwrapper.cpp
Fix typos reported by codespell
2018-09-04 13:11:26 +02:00
dbwrapper.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
dummywallet.cpp
interfaces: Add getWalletDir and listWalletDir to Node
2018-10-18 23:26:06 +01:00
fs.cpp
utils: Fix broken Windows filelock
2018-10-19 02:29:25 +08:00
fs.h
utils: Add fsbridge fstream function wrapper
2018-09-26 08:47:42 +08:00
hash.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
hash.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
httprpc.cpp
convert C-style (void) parameter lists to C++ style ()
2018-09-13 10:36:41 -07:00
httprpc.h
Cleanup StartRest()
2018-08-11 09:34:47 +03:00
httpserver.cpp
Merge #14214: convert C-style (void) parameter lists to C++ style ()
2018-09-20 17:57:20 -04:00
httpserver.h
convert C-style (void) parameter lists to C++ style ()
2018-09-13 10:36:41 -07:00
indirectmap.h
…
init.cpp
Merge #14282: [wallet] Remove -usehd
2018-09-26 17:36:28 -04:00
init.h
[build] remove ENABLE_WALLET ifdef from httprpc.cpp
2018-09-10 14:27:32 -04:00
key_io.cpp
Merge #13769: Mark single-argument constructors "explicit"
2018-08-27 13:33:04 -04:00
key_io.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
key.cpp
Pass export privkey DER compression flag correctly
2018-09-13 09:58:26 +02:00
key.h
convert C-style (void) parameter lists to C++ style ()
2018-09-13 10:36:41 -07:00
keystore.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
keystore.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
limitedmap.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
logging.cpp
Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP)
2018-08-29 16:05:00 +02:00
logging.h
logging: Replace LogPrint macros with regular functions
2018-09-12 11:28:01 -04:00
Makefile.am
build: Add --disable-bip70 configure option
2018-10-09 03:36:14 -06:00
Makefile.bench.include
build: Remove libssl from LDADD unless gui
2018-09-13 15:53:51 -04:00
Makefile.leveldb.include
…
Makefile.qt.include
build: Fix Qt link order for Windows build
2018-10-25 20:14:48 +08:00
Makefile.qttest.include
build: Add --disable-bip70 configure option
2018-10-09 03:36:14 -06:00
Makefile.test.include
Merge #14146: wallet: Remove trailing separators from -walletdir arg
2018-10-18 10:58:59 +02:00
memusage.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
merkleblock.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
merkleblock.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
miner.cpp
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00
miner.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
net_processing.cpp
Merge #14027: Skip stale tip checking if outbound connections are off or if reindexing.
2018-09-27 11:18:47 -04:00
net_processing.h
Merge #14331: doxygen: Fix member comments
2018-09-30 22:15:37 -03:00
net.cpp
Merge #14335: net: refactor: cleanup ThreadSocketHandler
2018-10-16 17:20:34 +02:00
net.h
Merge #14335: net: refactor: cleanup ThreadSocketHandler
2018-10-16 17:20:34 +02:00
netaddress.cpp
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00
netaddress.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
netbase.cpp
doxygen: Fix member comments
2018-09-26 15:42:21 -04:00
netbase.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
netmessagemaker.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
noui.cpp
noui: Move handlers to header file
2018-09-06 15:00:01 -04:00
noui.h
noui: Move handlers to header file
2018-09-06 15:00:01 -04:00
outputtype.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
outputtype.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pow.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pow.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
prevector.h
Explicitly initialize prevector _union
2018-08-27 09:50:13 -07:00
protocol.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
protocol.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pubkey.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
pubkey.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
random.cpp
scripted-diff: Small locking rename
2018-08-31 10:00:38 -04:00
random.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
rest.cpp
Consolidate redundant implementations of ParseHashStr
2018-09-25 09:14:52 -07:00
reverse_iterator.h
scripted-diff: Remove trailing whitespaces
2018-07-24 20:46:23 +01:00
reverselock.h
…
scheduler.cpp
convert C-style (void) parameter lists to C++ style ()
2018-09-13 10:36:41 -07:00
scheduler.h
convert C-style (void) parameter lists to C++ style ()
2018-09-13 10:36:41 -07:00
serialize.h
Drop minor GetSerializeSize template
2018-09-11 00:58:13 -04:00
shutdown.cpp
Break circular dependency: init -> * -> init by extracting shutdown.h
2018-06-25 00:08:49 -04:00
shutdown.h
Break circular dependency: init -> * -> init by extracting shutdown.h
2018-06-25 00:08:49 -04:00
span.h
Add more methods to Span class
2018-07-27 11:52:18 -07:00
streams.h
Fix typos reported by codespell
2018-09-04 13:11:26 +02:00
sync.cpp
Merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection
2018-08-31 16:00:38 +02:00
sync.h
scripted-diff: Small locking rename
2018-08-31 10:00:38 -04:00
threadinterrupt.cpp
Merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection
2018-08-31 16:00:38 +02:00
threadinterrupt.h
scripted-diff: Small locking rename
2018-08-31 10:00:38 -04:00
threadsafety.h
Trivial: update clang thread-safety docs url
2018-09-02 02:49:30 -04:00
timedata.cpp
Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
2018-08-27 18:19:33 +02:00
timedata.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
tinyformat.h
Fix typos
2018-03-21 08:34:44 +02:00
torcontrol.cpp
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00
torcontrol.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
txdb.cpp
Return void instead of bool for functions that cannot fail
2018-07-27 13:19:03 +02:00
txdb.h
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00
txmempool.cpp
Pass tx pool reference into CheckSequenceLocks
2018-09-11 12:08:17 -04:00
txmempool.h
doxygen: Fix member comments
2018-09-26 15:42:21 -04:00
ui_interface.cpp
Merge #13634: ui: Compile boost::signals2 only once
2018-08-13 15:02:38 -04:00
ui_interface.h
Make macro compatible with MSVC
2018-08-14 09:19:47 +00:00
uint256.cpp
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)
2018-10-26 19:42:58 +02:00
uint256.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
undo.h
Drop unused GetType() from CSizeComputer
2018-09-11 00:58:05 -04:00
util.cpp
Merge #13878: utils: Add fstream wrapper to allow to pass unicode filename on Windows
2018-10-18 10:36:51 +02:00
util.h
utils: Convert Windows args to utf-8 string
2018-09-30 15:08:16 +08:00
utilmemory.h
Extract MakeUnique into utilmemory.h
2018-07-17 13:56:21 -04:00
utilmoneystr.cpp
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)
2018-10-26 19:42:58 +02:00
utilmoneystr.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
utilstrencodings.cpp
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)
2018-10-26 19:42:58 +02:00
utilstrencodings.h
Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)
2018-10-26 19:42:58 +02:00
utiltime.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
utiltime.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
validation.cpp
Merge #13783: validation: Pass tx pool reference into CheckSequenceLocks
2018-10-27 10:39:44 -04:00
validation.h
Merge #13783: validation: Pass tx pool reference into CheckSequenceLocks
2018-10-27 10:39:44 -04:00
validationinterface.cpp
Add compile time checking for all cs_main runtime locking assertions
2018-08-26 00:25:28 +02:00
validationinterface.h
Add compile time checking for all cs_main runtime locking assertions
2018-08-26 00:25:28 +02:00
version.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
versionbits.cpp
MOVEONLY: Move versionbits info out of versionbits.o
2018-09-23 22:55:11 +02:00
versionbits.h
MOVEONLY: Move versionbits info out of versionbits.o
2018-09-23 22:55:11 +02:00
versionbitsinfo.cpp
MOVEONLY: Move versionbits info out of versionbits.o
2018-09-23 22:55:11 +02:00
versionbitsinfo.h
MOVEONLY: Move versionbits info out of versionbits.o
2018-09-23 22:55:11 +02:00
walletinitinterface.h
[build] remove ENABLE_WALLET ifdef from httprpc.cpp
2018-09-10 14:27:32 -04:00
warnings.cpp
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
warnings.h
Merge #13780: 0.17: Pre-branch maintenance
2018-08-08 13:55:27 +02:00