sami7777/nyc3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make CMutableTransaction constructor explicit

Browse Source 
Silently converting to a CMutableTransaction will drop all caches
and should thus be done explicitly
This commit is contained in:
MarcoFalke
2018-05-04 17:38:49 -04:00
parent f82e1c9482
commit faab55fbb1
7 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/wallet.cpp
+2 -2
View File
@@ -2065,8 +2065,8 @@ bool CWalletTx::IsTrusted() const
bool CWalletTx::IsEquivalentTo(const CWalletTx& _tx) const
{
CMutableTransaction tx1 = *this->tx;
CMutableTransaction tx2 = *_tx.tx;
CMutableTransaction tx1 {*this->tx};
CMutableTransaction tx2 {*_tx.tx};
for (auto& txin : tx1.vin) txin.scriptSig = CScript();
for (auto& txin : tx2.vin) txin.scriptSig = CScript();
return CTransaction(tx1) == CTransaction(tx2);